Fix Cmd+Enter steering of queued follow-ups - #924
Merged
Conversation
Route Cmd/Ctrl+Enter in a busy composer to the existing queue steerer instead of fullscreen. Reuse its cancellation and queue-drain guards so the next queued message runs once without consuming an unsent draft. Leave ordinary Enter and other desktop shortcuts unchanged, and exclude legacy IME confirmation from desktop shortcuts. Cover empty-composer steering, draft retention, chat isolation, and exactly-once dispatch through the composer interaction suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Modified Enter previously fell through to fullscreen instead of steering. Reusing the existing queue steerer keeps cancellation, queue editing guards, and queue draining on the same path as the Steer now action, rather than introducing a second dispatch path that could resend the message. The shortcut targets the next queued entry; selecting a different entry remains available through its existing action.
Verification
cd apps/native && bun run build— passed.cd apps/native && bun run test:desktop— passed.cd apps/native && bun run test:interactions— passed, including controlled-stream coverage for empty-composer steering, draft retention, chat isolation, IME/repeat guards, and exactly-once queued delivery.scripts/eval-tier1.sh— passed through the tracked pre-push hook.git diff --check— passed.Fixes #915