fix(gui): restore prompt focus and synchronize scroll verification - #927
Merged
Merged
Conversation
Request composer focus on explicit navigation, including repeated selection, without redirecting ordinary pane interaction. Focus the destination in the navigation commit so later renders do not steal typing focus. Wait for trusted wheel delivery at the intended scroller instead of treating a fixed delay as delivery evidence. Preserve strict event and scroll assertions, and establish renderer focus before measuring input targets. Add real-pointer navigation coverage. Verified the desktop unit suite, production build, interaction and repeated overflow suites, delayed and dropped wheel fault checks, and the full tier-1 gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Focus the destination prompt after New chat, Home, and session navigation, including repeated selection. Add real-pointer navigation regression coverage. Make the overflow probe wait for trusted wheel delivery at its intended scroller.
Why
Navigation could leave keyboard focus on the clicked control. Explicit navigation requests focus in the same render commit without redirecting ordinary pane interaction or adding delayed focus retries.
The scroll probe treated a fixed delay as event-delivery evidence. Establish renderer focus before measuring targets, then await delivery while retaining strict trusted-event and local-scroll assertions. Missing events still fail; the probe does not reinject input to obtain a pass.
Verification
bun run build— passed.bun run test:desktop— passed.bun run test:interactions— passed, including the new navigation regression.bun run test:overflow— passed on repeated runs.scripts/eval-tier1.sh— passed, including the pre-push gate.git diff --check— passed.Closes #896.
Closes #898.
#897 is handled separately by #906; its changes are not duplicated here.