Integrate canonical cockpit and accessible, retryable uploads - #210
Merged
Conversation
…evidence # Conflicts: # src/server/evidence/ingestion.ts
…-recovery-20260912
…-recovery-20260912
…-recovery-20260912
…ckpit-accessibility-20260912
…ccessibility-20260912
…-recovery-20260912
…ckpit-accessibility-20260912
justsml
marked this pull request as ready for review
September 12, 2026 21:02
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose canonical target inventory and cockpit queues, and integrate accessible dialogs plus bounded folder uploads. Preserve failed/cancelled files for retry, preserve successful evidence on cancellation without starting a chat turn, and guard unsaved settings when switching dialogs. Keyboard model navigation uses the current picker.
The #160 artifact-preview change is excluded because it breaks the existing report response and bypasses the proposed custody owner. The integration disposition and remaining blockers are documented in docs/branch-integration-2026-09-12.md.
Validation: typecheck, production build and Biome passed; upload-admission unit and target-inventory API tests passed. The five new production Chromium checks passed (dirty dialog transition, folder rejection, partial failure, cancellation, canonical records and keyboard model selection); all 27 production browser tests passed. Combined local suites passed: 190 unit, 1,158 integration, 852 eval and 50 package tests; 6 integration tests skipped. The subsequent credential-fixture isolation also passed all 5 focused profile tests. Synthetic upload and cockpit fixtures are not live research evidence. No paid model calls.
Merge after #207, #208 and #209 with exact-head hosted checks green. Original branch refs and worktrees are preserved.