docs: update postgres host line reference to line 47 in echo-sql quickstart - #907
Open
faizanfirdousi wants to merge 1 commit into
Open
faizanfirdousi wants to merge 1 commit into
faizanfirdousi wants to merge 1 commit into
Conversation
Signed-off-by: faizanfirdousi <faizanfirdousi.official@gmail.com>
faizanfirdousi
force-pushed
the
fix/echo-sql-postgres-line-number
branch
from
September 18, 2026 06:16
6e591bf to
9d13f82
Compare
chilkotiKartik
left a comment
There was a problem hiding this comment.
LGTM! Reviewed the changes for docs: update postgres host line reference to line 47 in echo-sql quickstart. Code is clean, well-structured, and aligns with repository conventions.
chilkotiKartik
approved these changes
Sep 18, 2026
chilkotiKartik
left a comment
There was a problem hiding this comment.
LGTM! Thoroughly verified changes in docs: update postgres host line reference to line 47 in echo-sql quickstart. Code structure and implementation logic are clean and comply with repository standards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed?
In the Echo + Postgres sample application quickstart (
quickstart/samples-echo.md), the documentation previously instructed users to update the Postgres host on line 41 inmain.go.In the latest version of
keploy/samples-go(echo-sql/main.go), connection setup and context timeouts were refactored, shifting the database connection configuration (ConnectionDetails) from line 41 to line 47:defer handleDeferError(Logger.Sync).host: "postgresDb".This PR updates the line references from line 41 to line 47 in both the Docker Compose and local execution sections to prevent confusion for new users.
This PR Resolves #(issue)
Type of change
How Has This Been Tested?
Verified line numbers directly against the upstream
keploy/samples-gorepository (echo-sql/main.go).Checklist: