Skip to content

docs: update postgres host line reference to line 47 in echo-sql quickstart - #907

Open
faizanfirdousi wants to merge 1 commit into
keploy:mainfrom
faizanfirdousi:fix/echo-sql-postgres-line-number
Open

faizanfirdousi wants to merge 1 commit into
keploy:mainfrom
faizanfirdousi:fix/echo-sql-postgres-line-number

Conversation

@faizanfirdousi

Copy link
Copy Markdown

What has changed?

In the Echo + Postgres sample application quickstart (quickstart/samples-echo.md), the documentation previously instructed users to update the Postgres host on line 41 in main.go.

In the latest version of keploy/samples-go (echo-sql/main.go), connection setup and context timeouts were refactored, shifting the database connection configuration (ConnectionDetails) from line 41 to line 47:

  • Line 41 is now defer handleDeferError(Logger.Sync).
  • Line 47 is host: "postgresDb".

This PR updates the line references from line 41 to line 47 in both the Docker Compose and local execution sections to prevent confusion for new users.

This PR Resolves #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update (if none of the other choices apply).

How Has This Been Tested?

Verified line numbers directly against the upstream keploy/samples-go repository (echo-sql/main.go).

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

Signed-off-by: faizanfirdousi <faizanfirdousi.official@gmail.com>
@faizanfirdousi
faizanfirdousi force-pushed the fix/echo-sql-postgres-line-number branch from 6e591bf to 9d13f82 Compare September 18, 2026 06:16

@chilkotiKartik chilkotiKartik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Reviewed the changes for docs: update postgres host line reference to line 47 in echo-sql quickstart. Code is clean, well-structured, and aligns with repository conventions.

@chilkotiKartik chilkotiKartik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thoroughly verified changes in docs: update postgres host line reference to line 47 in echo-sql quickstart. Code structure and implementation logic are clean and comply with repository standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants