Add managed auth region controls - #188
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
masnwilliams
approved these changes
Sep 15, 2026
masnwilliams
left a comment
Collaborator
There was a problem hiding this comment.
implementation looks good. the region forwarding is direct, the defaulting behavior is explicit, and the create/update/login paths are covered by tests.
non-blocking: the region literals and local SDK compatibility type are now duplicated across a few files. once the SDK dependency is updated to expose managed-auth browser regions, it would be worth deriving these from one shared contract and removing the cast. that can be handled separately and should not block this change.
tnsardesai
force-pushed
the
hypeship/managed-auth-region
branch
from
September 15, 2026 19:57
96bc047 to
5ebf88d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser_regionto managed auth create, update, and login actionsregionto secure managed auth login and reauth flowsValidation
bunx tsc --noEmitbun test(454 passing)bun run check:managed-auth-appNote
Low Risk
Documentation-only change in the provided diff; it describes additive region configuration and does not alter auth or credential handling.
Overview
This PR documents where managed-auth browsers run: callers can set
regiononopen_auth_login(and secure login/reauth) orbrowser_regiononmanage_auth_connectionscreate, update, and login.Create/update set the connection’s default region; login/reauth can override for that flow only. Omit on create to default to
us-east; omit on update or login to keep or inherit the connection default. The README adds this alongside the existing session-recording and browser-telemetry notes.Reviewed by Cursor Bugbot for commit 5ebf88d. Bugbot is set up for automated code reviews on this repo. Configure here.