Support credential collection and browser fill through MCP - #192
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 58601b0. Configure here.
masnwilliams
left a comment
There was a problem hiding this comment.
reviewed at 58601b0. no blocking findings.
The revised implementation keeps the new credential write surface focused, isolates fill validation/result handling in vault-fill.ts, rechecks API-advertised availability before invoking, and treats uncertain outcomes conservatively. The secret/public-value projection and error paths have strong boundary coverage. No production file crosses the 1k-line threshold.
Non-blocking follow-ups:
- The tool description could spell out
action: "invoke"+operation: "collect"instead of referring to"collect"alone. - If wildcard record projection expands beyond these credential maps, replace the
"*"sentinel with an explicit typed record node. Its current localized use does not justify blocking this PR.
Validated locally: 599 tests, TypeScript, changed-file Prettier, and git diff --check pass.
|
Addressed the collection guidance in 0e74a2d: both tool descriptions and credential response guidance now spell out action: "invoke" and operation: "collect". Added discovery assertions; all 603 tests and TypeScript pass. Kept the wildcard record projection localized as suggested; an explicit typed record node can replace it if usage expands. |

Summary
manage_vault_credentialsfor creation and version-guarded updates, including optional immutableexpected_item_id, initial values, and null/empty clearing. Definitions remain immutable.manage_vault_itemsinvocation offillwith a typed, value-freefillobject. Fetch current advertised operations before writing. Preserve ordered fill outcomes; failed/unknown outcomes return tool errors with explicit no-retry guidance. Pre-write API errors preserve HTTP status and allowlisted codes with actionable explanations; the API owns destination/format validation. Transport loss and malformed responses are treated as unconfirmed, never replayed.prepare_checkoutremains API/CLI-only. Fill supports credentials and advertised Link cards, not AgentCard. Form submission remains a separate authorized browser action.SDK
The existing dependency and frozen lockfile already use the latest published Node SDK verified for this work:
@onkernel/sdk0.104.0. No dependency churn.Validation
bun test: 603 passed.bunx tsc --noEmit: passed.git diff --check: passed.KERNEL_CLI_PROD_CLIENT_ID.