Version 4.4.0

.github/workflows/pull-request.yml

@@ -10,11 +10,11 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: set up JDK 17
-        uses: actions/setup-java@v3
+      - name: set up JDK 21
+        uses: actions/setup-java@v4
         with:
           distribution: 'oracle'
-          java-version: 17
+          java-version: 21
           cache: 'gradle'
 
       - name: Unit tests
@@ -36,11 +36,11 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-gradle-
 
-      - name: set up JDK 17
-        uses: actions/setup-java@v3
+      - name: set up JDK 21
+        uses: actions/setup-java@v4
         with:
           distribution: 'oracle'
-          java-version: 17
+          java-version: 21
           cache: 'gradle'
 
       - name: Ktlint check
@@ -101,11 +101,11 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-gradle-
 
-      - name: set up JDK 17
-        uses: actions/setup-java@v3
+      - name: set up JDK 21
+        uses: actions/setup-java@v4
         with:
           distribution: 'oracle'
-          java-version: 17
+          java-version: 21
           cache: 'gradle'
 
       - name: Setup Android SDK

.github/workflows/testing.yml

@@ -16,11 +16,11 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: set up JDK 17
-        uses: actions/setup-java@v3
+      - name: set up JDK 21
+        uses: actions/setup-java@v4
         with:
           distribution: 'oracle'
-          java-version: 17
+          java-version: 21
           cache: 'gradle'
 
       - name: Unit tests
@@ -42,11 +42,11 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-gradle-
 
-      - name: set up JDK 17
-        uses: actions/setup-java@v3
+      - name: set up JDK 21
+        uses: actions/setup-java@v4
         with:
           distribution: 'oracle'
-          java-version: 17
+          java-version: 21
           cache: 'gradle'
 
       - name: Ktlint check
@@ -113,11 +113,11 @@ jobs:
           property: VERSION_NUM
           value: ${{ github.run_number }}
 
-      - name: set up JDK 17
-        uses: actions/setup-java@v3
+      - name: set up JDK 21
+        uses: actions/setup-java@v4
         with:
           distribution: 'oracle'
-          java-version: 17
+          java-version: 21
           cache: 'gradle'
 
       - name: Setup Android SDK

README.md

@@ -17,6 +17,10 @@
 <noscript><a href="https://buy.stripe.com/00g16L9YEabldDWdQQ"><img alt="Donate using Stripe" src="https://img.shields.io/badge/Donate-Stripe-blueviolet?style=for-the-badge&logo=stripe"></a></noscript>
 </p>
 
+<p align="center">
+<img width="700"  src="https://github.com/user-attachments/assets/0411203c-4490-42ff-8aff-667cbde32f49" />
+</p>
+
 ## Unleash your keys!
 
 Make custom macros on your keyboard or gamepad, make on-screen buttons in any app, and unlock new functionality from your volume buttons!

app/src/main/AndroidManifest.xml

@@ -10,6 +10,20 @@
         android:name="android.hardware.touchscreen"
         android:required="false" />
 
+    <!--
+        Requested only in this FOSS build. Android TV has no usable file picker
+        (system SAF/share intents resolve to fake stub activities that always
+        fail — see HomeKeyMapListScreen.kt's import/export handling), so
+        importing a backup requires browsing Downloads directly. Google Play
+        restricts MANAGE_EXTERNAL_STORAGE to file-manager apps, but Android TV
+        users overwhelmingly sideload this FOSS build rather than installing
+        from Play, so it's safe to request here. Do not add this to the Play
+        Store (app/) manifest.
+    -->
+    <uses-permission
+        android:name="android.permission.MANAGE_EXTERNAL_STORAGE"
+        tools:ignore="ScopedStorage" />
+
     <!--  This is required because sysbridge has a min sdk of 29 since it depends
       on the binder-ndk library. Building will fail without this because the min sdk
       of the app is 26.-->

app/src/main/java/io/github/sds100/keymapper/AppHiltModule.kt

@@ -42,6 +42,12 @@ class AppHiltModule {
             get() = BuildConfig.VERSION_CODE
         override val sdkInt: Int
             get() = Build.VERSION.SDK_INT
+
+        // Android TV users predominantly sideload this FOSS build rather than
+        // install from Google Play, which restricts this permission to
+        // file-manager apps, so it's safe to request it here.
+        override val canRequestAllFilesAccess: Boolean
+            get() = true
     }
 
     @Singleton

app/version.properties

@@ -1,2 +1,2 @@
-VERSION_NAME=4.3.1
-VERSION_CODE=259
+VERSION_NAME=4.4.0
+VERSION_CODE=264

base/build.gradle.kts

@@ -68,6 +68,27 @@ android {
     composeOptions {
         kotlinCompilerExtensionVersion = libs.versions.compose.compiler.get()
     }
+
+    testOptions {
+        unitTests {
+            isIncludeAndroidResources = true
+        }
+
+        // Needed for Roboelectric to work on Java 17+
+        unitTests.all {
+            it.jvmArgs(
+                "--add-opens=java.base/java.lang=ALL-UNNAMED",
+                "--add-opens=java.base/java.util=ALL-UNNAMED",
+                "--add-opens=java.base/java.io=ALL-UNNAMED",
+                "--add-opens=java.base/java.net=ALL-UNNAMED",
+                "--add-opens=java.base/java.security=ALL-UNNAMED",
+                "--add-opens=java.base/java.text=ALL-UNNAMED",
+                "--add-opens=java.base/jdk.internal.access=ALL-UNNAMED",
+                "--add-opens=java.desktop/java.awt.font=ALL-UNNAMED",
+                "--add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED",
+            )
+        }
+    }
 }
 
 dependencies {

base/src/main/java/io/github/sds100/keymapper/base/BaseMainActivity.kt

@@ -1,5 +1,6 @@
 package io.github.sds100.keymapper.base
 
+import android.content.ActivityNotFoundException
 import android.content.BroadcastReceiver
 import android.content.Context
 import android.content.Intent
@@ -8,6 +9,7 @@ import android.content.res.Configuration
 import android.net.Uri
 import android.os.Bundle
 import android.view.MotionEvent
+import android.widget.Toast
 import androidx.activity.SystemBarStyle
 import androidx.activity.enableEdgeToEdge
 import androidx.activity.result.contract.ActivityResultContracts.CreateDocument
@@ -276,9 +278,27 @@ abstract class BaseMainActivity : AppCompatActivity() {
         val fileUri =
             IntentCompat.getParcelableExtra(intent, EXTRA_FILE_URI, Uri::class.java) ?: return
 
+        saveFileToUserChosenLocation(fileUri)
+    }
+
+    /**
+     * Let the user pick a location to save [fileUri] to using the system document picker.
+     * This is used as a fallback for exporting when there is no app installed that can
+     * receive a shared file, for example on Android TV.
+     */
+    fun saveFileToUserChosenLocation(fileUri: Uri) {
         val fileName = fileUri.toDocumentFile(this@BaseMainActivity)?.name ?: return
 
         originalFileUri = fileUri
-        saveFileLauncher.launch(fileName)
+
+        try {
+            saveFileLauncher.launch(fileName)
+        } catch (_: ActivityNotFoundException) {
+            Toast.makeText(
+                this,
+                R.string.dialog_message_no_app_found_to_create_file,
+                Toast.LENGTH_LONG,
+            ).show()
+        }
     }
 }

base/src/main/java/io/github/sds100/keymapper/base/BaseMainNavHost.kt

@@ -28,6 +28,7 @@ import io.github.sds100.keymapper.base.constraints.ChooseConstraintViewModel
 import io.github.sds100.keymapper.base.debug.GetEventScreen
 import io.github.sds100.keymapper.base.expertmode.ExpertModeScreen
 import io.github.sds100.keymapper.base.expertmode.ExpertModeSetupScreen
+import io.github.sds100.keymapper.base.expertmode.xiaomi.XiaomiOptimizationScreen
 import io.github.sds100.keymapper.base.logging.LogScreen
 import io.github.sds100.keymapper.base.onboarding.HandleAccessibilityServiceDialogs
 import io.github.sds100.keymapper.base.onboarding.SetupAccessibilityServiceDelegateImpl
@@ -158,6 +159,13 @@ fun BaseMainNavHost(
             )
         }
 
+        composable<NavDestination.XiaomiOptimization> {
+            XiaomiOptimizationScreen(
+                modifier = Modifier.fillMaxSize(),
+                viewModel = hiltViewModel(),
+            )
+        }
+
         composable<NavDestination.Log> {
             LogScreen(
                 modifier = Modifier.fillMaxSize(),

base/src/main/java/io/github/sds100/keymapper/base/BaseViewModelHiltModule.kt

@@ -29,6 +29,8 @@ import io.github.sds100.keymapper.base.expertmode.ExpertModeSetupDelegateImpl
 import io.github.sds100.keymapper.base.expertmode.SystemBridgeSetupDelegate
 import io.github.sds100.keymapper.base.expertmode.SystemBridgeSetupUseCase
 import io.github.sds100.keymapper.base.expertmode.SystemBridgeSetupUseCaseImpl
+import io.github.sds100.keymapper.base.expertmode.xiaomi.XiaomiOptimizationUseCase
+import io.github.sds100.keymapper.base.expertmode.xiaomi.XiaomiOptimizationUseCaseImpl
 import io.github.sds100.keymapper.base.home.ListKeyMapsUseCase
 import io.github.sds100.keymapper.base.home.ListKeyMapsUseCaseImpl
 import io.github.sds100.keymapper.base.home.ShowHomeScreenAlertsUseCase
@@ -200,4 +202,10 @@ abstract class BaseViewModelHiltModule {
     abstract fun bindExpertModeSetupDelegate(
         impl: ExpertModeSetupDelegateImpl,
     ): SystemBridgeSetupDelegate
+
+    @Binds
+    @ViewModelScoped
+    abstract fun bindXiaomiOptimizationUseCase(
+        impl: XiaomiOptimizationUseCaseImpl,
+    ): XiaomiOptimizationUseCase
 }

base/src/main/java/io/github/sds100/keymapper/base/actions/ActionData.kt

@@ -5,6 +5,7 @@ import io.github.sds100.keymapper.common.models.ShellExecutionMode
 import io.github.sds100.keymapper.common.utils.NodeInteractionType
 import io.github.sds100.keymapper.common.utils.Orientation
 import io.github.sds100.keymapper.common.utils.PinchScreenType
+import io.github.sds100.keymapper.common.utils.SizeKM
 import io.github.sds100.keymapper.system.camera.CameraLens
 import io.github.sds100.keymapper.system.intents.IntentExtraModel
 import io.github.sds100.keymapper.system.intents.IntentTarget
@@ -245,6 +246,11 @@ sealed class ActionData : Comparable<ActionData> {
         }
     }
 
+    @Serializable
+    data object CycleKeyboardLanguage : ActionData() {
+        override val id = ActionId.CYCLE_KEYBOARD_LANGUAGE
+    }
+
     @Serializable
     sealed class DoNotDisturb : ActionData() {
 
@@ -378,12 +384,18 @@ sealed class ActionData : Comparable<ActionData> {
         }
 
         @Serializable
-        data class StepForward(override val packageName: String) : ControlMediaForApp() {
+        data class StepForward(
+            override val packageName: String,
+            val stepDurationMs: Long? = null,
+        ) : ControlMediaForApp() {
             override val id = ActionId.STEP_FORWARD_PACKAGE
         }
 
         @Serializable
-        data class StepBackward(override val packageName: String) : ControlMediaForApp() {
+        data class StepBackward(
+            override val packageName: String,
+            val stepDurationMs: Long? = null,
+        ) : ControlMediaForApp() {
             override val id = ActionId.STEP_BACKWARD_PACKAGE
         }
     }
@@ -431,12 +443,12 @@ sealed class ActionData : Comparable<ActionData> {
         }
 
         @Serializable
-        data object StepForward : ControlMedia() {
+        data class StepForward(val stepDurationMs: Long? = null) : ControlMedia() {
             override val id = ActionId.STEP_FORWARD
         }
 
         @Serializable
-        data object StepBackward : ControlMedia() {
+        data class StepBackward(val stepDurationMs: Long? = null) : ControlMedia() {
             override val id = ActionId.STEP_BACKWARD
         }
     }
@@ -457,7 +469,16 @@ sealed class ActionData : Comparable<ActionData> {
     }
 
     @Serializable
-    data class TapScreen(val x: Int, val y: Int, val description: String?) : ActionData() {
+    data class TapScreen(
+        val x: Int,
+        val y: Int,
+        val description: String?,
+        /**
+         * The display size that the coordinates were picked for. See issue #2217. This is null for
+         * actions that were created before the resolution was saved and those are never scaled.
+         */
+        val screenResolution: SizeKM? = null,
+    ) : ActionData() {
         override val id = ActionId.TAP_SCREEN
 
         override fun compareTo(other: ActionData) = when (other) {
@@ -482,6 +503,11 @@ sealed class ActionData : Comparable<ActionData> {
         val fingerCount: Int,
         val duration: Int,
         val description: String?,
+        /**
+         * The display size that the coordinates were picked for. See issue #2217. This is null for
+         * actions that were created before the resolution was saved and those are never scaled.
+         */
+        val screenResolution: SizeKM? = null,
     ) : ActionData() {
         override val id = ActionId.SWIPE_SCREEN
 
@@ -511,6 +537,12 @@ sealed class ActionData : Comparable<ActionData> {
         val fingerCount: Int,
         val duration: Int,
         val description: String?,
+        /**
+         * The display size that the coordinates and distance were picked for. See issue #2217. This
+         * is null for actions that were created before the resolution was saved and those are never
+         * scaled.
+         */
+        val screenResolution: SizeKM? = null,
     ) : ActionData() {
         override val id = ActionId.PINCH_SCREEN