Conversation
🤖 Generated with [OpenCode](https://opencode.ai) (Gemini)
🤖 Security Review DashboardStatus: 1 open issue · Scanned commit
Comment with |
komoot-guardian
left a comment
There was a problem hiding this comment.
🤖 Security findings on 26d35c6 — tracked in Security Review Dashboard.
| @@ -1,3 +1,4 @@ | |||
| --index-url https://${ARTIFACTORY_USERNAME}:${ARTIFACTORY_ACCESS_TOKEN}@proxy.registry.bendingspoons.com/pypi/simple | |||
There was a problem hiding this comment.
🤖 Security Issue [sha=26d35c6]: Credential-bearing pip index URL in public repo
A pip index URL embedding $ARTIFACTORY_USERNAME/$ARTIFACTORY_ACCESS_TOKEN is added to a tracked file in the public komoot/staticmap repository, inviting anyone troubleshooting the build to substitute real Artifactory credentials that would then be published in Git history. See 26d35c6:requirements.txt:L1. Sibling BSP repos set this via CI-provided PIP_INDEX_URL, but this repo has no workflows, so the line only becomes functional by pasting real secrets locally.
Fix: Point this public repo at a credential-free index (or export PIP_INDEX_URL from a CI secret store) instead of embedding credential placeholders in requirements.txt.
Severity: medium
|
Closed: repository is public and should not point to internal Artifactory. |
Add BSP Python registry proxy index URL to
requirements.txtto resolve supply-chain security findings.🤖 Generated with OpenCode (Gemini)