Update node_readiness_evaluation_duration_seconds + tests

[rawadhossain]

Description

• Updates HELP string on node_readiness_evaluation_duration_seconds to include taint operations. No name, label, or bucket change.
• Adds related tests to internal/metrics/metrics_test.go, also contributes to testing: Add Test Coverage for Prometheus Metrics #269.

from the design doc:

Related to #446

Type of Change

/kind documentation

Testing

make test, make lint, go vet, gofmt -l all pass.

Checklist

• make test passes
• make lint passes

[netlify]

✅ Deploy Preview for node-readiness-controller ready!

Name	Link
🔨 Latest commit	5ed9a3f
🔍 Latest deploy log	https://app.netlify.com/projects/node-readiness-controller/deploys/6a9676e176d95a000877f789
😎 Deploy Preview	https://deploy-preview-447--node-readiness-controller.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rawadhossain
Once this PR has been reviewed and has the lgtm label, please assign ajaysundark for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubernetes-prow]

Hi @rawadhossain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rawadhossain]

/cc @AvineshTripathi

[AvineshTripathi]

/ok-to-test

[rawadhossain]

/retest

[AvineshTripathi]

I feel we are adding redundancy here for every metric test. All the metrics-related test cases, unless they have a special case, will follow the same structure i.e.

1. Check if they are getting registered and have correct help and format etc
2. a case where we test the reflection(a change is done and we want that change to reflect it)

I feel we can give a generic test or maybe reuse for above cases

[AvineshTripathi]

Suggested change

	Help: "Duration of rule evaluations per rule, including taint operations",
	Help: "End-to-end duration of rule evaluation, including any taint add/remove operations",

The current wording "Duration of rule evaluations per rule, including taint operations" reads as if the metric tracks two separate things. The suggested wording makes it clear that taint operations are part of what's being timed.

wdyt? Open to even better wording

[rawadhossain]

@AvineshTripathi I think that's a good point. Made the changes, now two reusable helpers used in tests and also updated the help text to Duration of evaluating a rule against a node, including any taint add/remove operations.

PTAL. Thanks!

[AvineshTripathi]

/lgtm

cc @ajaysundark for approval