fix: align toolchain with root go.mod and verify licenses in CI - #1003
Open
tiffanny29631 wants to merge 1 commit into
Open
tiffanny29631 wants to merge 1 commit into
tiffanny29631 wants to merge 1 commit into
Conversation
kubernetes-prow
Bot
added
kind/bug
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tiffanny29631 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
size/S
tiffanny29631
changed the title
sdowell
reviewed
Sep 19, 2026
| - name: Check licenses | ||
| working-directory: git-sync | ||
| run: | | ||
| make licenses |
Contributor
There was a problem hiding this comment.
This doesn't verify licenses, this generates licenses
What is the intent of the change?
Member
Can you explain more? It doesn't fail for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
/kind cleanup
This PR fixes a build failure during make container caused by a Go toolchain / GOROOT mismatch in go-licenses, and adds a lightweight CI check to ensure license verification is tested on every PR.