Validate question JSON before export - #50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A question can be perfectly valid JSON and still fail to import, or import and then render wrongly. Authors currently discover this by uploading and looking.
Done when in2lambda reports, before export, the problems it can reasonably detect: an answer box whose marking method does not fit its answer, a multiple choice whose options and answers disagree, an image that will not be found, and maths the platform cannot render (it uses KaTeX; for instance the usual degree symbol does not display). Each report should tell the author where to look.
The markdown delimiter checks added by PR #22 belong with these rather than in a second, separate checker.
Workbench ticket t8.