Skip to content

feat(api): update API spec from langfuse/langfuse 99e2ce9 - #1842

Merged
hassiebp merged 1 commit into
mainfrom
api-spec-bot-99e2ce9-33068188074-1
Aug 27, 2026
Merged

feat(api): update API spec from langfuse/langfuse 99e2ce9#1842
hassiebp merged 1 commit into
mainfrom
api-spec-bot-99e2ce9-33068188074-1

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

This generated API update marks deprecated v3 API operations and documents their v4 migration paths.

  • Adds static deprecation metadata to synchronous, asynchronous, typed, and raw API methods.
  • Adds typing-extensions as a direct dependency to support the decorators.
  • Refreshes the lockfile dependency metadata and resolution cutoff.

Confidence Score: 5/5

The PR appears safe to merge; no changed-code-triggered correctness or security defects were identified.

The decorators preserve endpoint behavior while adding deprecation metadata, synchronous and asynchronous surfaces remain aligned, and the newly direct typing-extensions dependency supports all added imports.

Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile

Context used (5)

@langfuse-bot
langfuse-bot requested a review from hassiebp August 27, 2026 11:39
@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional findings (outside the current diff — GitHub can't attach inline comments there):

  • 🟡 langfuse/_client/client.py — Internal supported SDK methods (get_dataset_run, get_dataset_runs, delete_dataset_run in langfuse/_client/client.py:2513-2589, and BatchEvaluation's trace-listing in langfuse/batch_evaluation.py:1167) call self.api.datasets.get_run/get_runs/delete_run and api.trace.list, which this diff now decorates with @ typing_extensions.deprecated. sweep:self\.api\.(datasets\.(get_run|get_runs|delete_run)|trace\.list)\(

    Extended reasoning...

    These public Langfuse SDK convenience methods are not themselves being deprecated/removed, but static type checkers that honor PEP 702 (e.g. pyright, which surfaces reportDeprecated hints by default) will now flag these legitimate, still-supported internal call sites as using a deprecated API, misleading maintainers/downstream type-checking users into thinking normal SDK usage (run_experiment, get_dataset_run, batch evaluation trace fetch) relies on removed functionality, when a correct fix would keep the raw v3 client marked deprecated for direct external callers while not surfacing false-positive deprecation diagnostics for the SDK's own maintained wrapper implementations.

    Verification: nit. The candidate's facts are correct: the diff adds @ typing_extensions.deprecated("...", category=None) to DatasetsClient.get_run/get_runs/delete_run (langfuse/api/datasets/client.py:174,223,272 + async variants) and trace.list (langfuse/api/trace/client.py), and these are called by still-supported internal SDK methods — langfuse/_client/client.py:2528 (self.api.datasets.get_run),…

@hassiebp
hassiebp merged commit 438d0ff into main Aug 27, 2026
23 checks passed
@hassiebp
hassiebp deleted the api-spec-bot-99e2ce9-33068188074-1 branch August 27, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants