chore: refresh build toolchain and bump appcompat - #16
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
chore: refresh build toolchain and bump appcompat#16devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
@cursor review |
kinyoklion
marked this pull request as ready for review
August 3, 2026 16:00
kinyoklion
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No LaunchDarkly SDK change needed —
launchdarkly-android-client-sdkis already pinned to5.13.2, the latest 5.x on Maven Central, and no deprecated SDK APIs are used (verified by compiling with-Xlint:deprecation: zero warnings). This PR only refreshes the build tooling and one stale AndroidX pin.androidx.appcompat:appcompat1.2.0→1.7.1(latest 1.x; the existing pin was from 2020). RequirescompileSdk≥ 34, which this project already targets.8.7.0→8.13.2and Gradle wrapper8.9→8.14.3(regenerated with./gradlew wrapper --gradle-version 8.14.3, hence thegradlew/gradlew.bat/gradle-wrapper.jarchurn). Both stay within their current major.=inapp/build.gradle, which Gradle 9 warns "will fail with an error in Gradle 10". Matches the same change already merged in the Kotlin sibling repo (chore: replace deprecated Resources.getColor and Gradle space-assignment DSL hello-android#46):applicationId,versionCode,versionName,minifyEnabled,source/targetCompatibility)How verified
./gradlew clean assembleDebug --warning-mode all— BUILD SUCCESSFUL, no deprecation warnings.my-boolean-flagkey is not defined in that project, so it falls back tofalse):Link to Devin session: https://app.devin.ai/sessions/bb345040611843e79e555dc72dfd5c54
Requested by: @jsonbailey
Note
Low Risk
Build and dependency version bumps only; no auth, data, or application runtime logic changes.
Overview
Refreshes the Android build stack without changing LaunchDarkly SDK usage or app logic.
Toolchain: Android Gradle Plugin 8.7.0 → 8.13.2, Gradle wrapper 8.9 → 8.14.3 (with updated
gradlew/gradlew.batand wrapper properties such asnetworkTimeoutandvalidateDistributionUrl).Dependencies:
androidx.appcompat:appcompat1.2.0 → 1.7.1 inapp/build.gradle.Gradle DSL: Space-style assignments in
app/build.gradleare switched to=(namespace,compileSdk,applicationId, versions,minifyEnabled, Java compatibility) to align with Gradle 9+ expectations.Reviewed by Cursor Bugbot for commit 6fa21d8. Bugbot is set up for automated code reviews on this repo. Configure here.