Skip to content

chore: refresh build toolchain and bump appcompat - #16

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1785748387-toolchain-refresh
Open

chore: refresh build toolchain and bump appcompat#16
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1785748387-toolchain-refresh

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

No LaunchDarkly SDK change needed — launchdarkly-android-client-sdk is already pinned to 5.13.2, the latest 5.x on Maven Central, and no deprecated SDK APIs are used (verified by compiling with -Xlint:deprecation: zero warnings). This PR only refreshes the build tooling and one stale AndroidX pin.

  • androidx.appcompat:appcompat 1.2.01.7.1 (latest 1.x; the existing pin was from 2020). Requires compileSdk ≥ 34, which this project already targets.
  • Android Gradle Plugin 8.7.08.13.2 and Gradle wrapper 8.98.14.3 (regenerated with ./gradlew wrapper --gradle-version 8.14.3, hence the gradlew/gradlew.bat/gradle-wrapper.jar churn). Both stay within their current major.
  • Groovy DSL space assignment → = in app/build.gradle, which Gradle 9 warns "will fail with an error in Gradle 10". Matches the same change already merged in the Kotlin sibling repo (chore: replace deprecated Resources.getColor and Gradle space-assignment DSL hello-android#46):
    - namespace "com.launchdarkly.hello_android"
    - compileSdk 34
    + namespace = "com.launchdarkly.hello_android"
    + compileSdk = 34
    (also applicationId, versionCode, versionName, minifyEnabled, source/targetCompatibility)

How verified

  • ./gradlew clean assembleDebug --warning-mode all — BUILD SUCCESSFUL, no deprecation warnings.
  • Installed the debug APK on an Android 34 x86_64 emulator with the hello-apps mobile key injected locally (never committed) and launched it. The SDK initialized and the flag evaluation rendered (the default my-boolean-flag key is not defined in that project, so it falls back to false):

hello-android-java running on emulator

Link to Devin session: https://app.devin.ai/sessions/bb345040611843e79e555dc72dfd5c54
Requested by: @jsonbailey


Note

Low Risk
Build and dependency version bumps only; no auth, data, or application runtime logic changes.

Overview
Refreshes the Android build stack without changing LaunchDarkly SDK usage or app logic.

Toolchain: Android Gradle Plugin 8.7.0 → 8.13.2, Gradle wrapper 8.9 → 8.14.3 (with updated gradlew / gradlew.bat and wrapper properties such as networkTimeout and validateDistributionUrl).

Dependencies: androidx.appcompat:appcompat 1.2.0 → 1.7.1 in app/build.gradle.

Gradle DSL: Space-style assignments in app/build.gradle are switched to = (namespace, compileSdk, applicationId, versions, minifyEnabled, Java compatibility) to align with Gradle 9+ expectations.

Reviewed by Cursor Bugbot for commit 6fa21d8. Bugbot is set up for automated code reviews on this repo. Configure here.

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

@cursor review

@kinyoklion
kinyoklion marked this pull request as ready for review August 3, 2026 16:00
@kinyoklion
kinyoklion requested a review from a team as a code owner August 3, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant