ci: Fix malformed rubocop disable directive - #439
Merged
Merged
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
kinyoklion
marked this pull request as ready for review
September 14, 2026 21:28
keelerm84
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops a stray trailing colon from a
# rubocop:disabledirective that RuboCop 1.91.0 now rejects, breakingPublish Package/build-ruby-gem.Naming/MethodName:->Naming/MethodNameinflag_builder.rbImplementation details
Root cause
build-ruby-gemfailed in theRun RuboCopstep of./.github/actions/check:Lint/CopDirectiveSyntaxwas added in RuboCop 1.72 as a pending cop and this repo setsNewCops: disable, so it stayed off. In RuboCop 1.91.0 (VersionChanged: '1.91'in the gem'sconfig/default.yml) it is enabled by default, so the pre-existing malformed directive started failing. The gemspec allowsrubocop "~> 1.76", so CI picked up 1.91.0 as soon as it released — nothing changed in the SDK source.Testing
bundle exec rubocopequivalent run locally with rubocop 1.91.0 + rubocop-performance 1.27.0: 1 offense before the change,186 files inspected, no offenses detectedafter.Alternatives considered
Pinning RuboCop below 1.91 in the gemspec would also unblock CI, but the directive is genuinely malformed (the disable never applied), so fixing it is the correct minimal change.
Link to Devin session: https://app.devin.ai/sessions/700251d712274fcfaabc41ae8e479b3f
Open in Devin Desktop: https://app.devin.ai/desktop/session/700251d712274fcfaabc41ae8e479b3f?variant=devin
Requested by: @kinyoklion
Note
Overview
Fixes Publish Package /
build-ruby-gemRuboCop failures introduced by RuboCop 1.91.0 by correcting a malformed# rubocop:disablecomment onFlagRuleClauseinflag_builder.rb.The directive had a stray trailing colon (
Naming/MethodName:);Lint/CopDirectiveSyntaxnow rejects that syntax. The change drops the colon so the disable applies as intended. No runtime or API behavior changes.Reviewed by Cursor Bugbot for commit 4b883a8. Bugbot is set up for automated code reviews on this repo. Configure here.