"native" numpy integration - #2
Open
shadoxxhd wants to merge 4 commits into
Open
Conversation
Author
|
breaking changes:
the substrip2 branch also returns numpy arrays instead of lists, but keeps the original arguments/validation logic of the PixelSubStrip constructor, but that could be trivially reverted with return type checks/conversions |
Author
|
compared to my original pull request, this is based on your force-pushed changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integration includes some breaking changes to the existing substrip interface, which to me seem more natural. If minimally disruptive numpy integration was preferred, my "substrip2" branch might be better suited (if desired, I'll make a pull request for that one).