run-vmtest: fail selftest runs that produce kernel splats - #229
Open
mykyta5 wants to merge 1 commit into
Open
Conversation
A non-fatal splat (WARN, KASAN report, lockdep, hung task) leaves the VM running, so the selftest binary still exits 0 and CI goes green on a kernel that just hit a real bug. We have no signal for these today. Scan dmesg after the run and add a kernel_splats row to the existing exitstatus aggregator. A scan that cannot run fails the row rather than reporting clean, otherwise a typo in a pattern file would quietly turn the check off. splat-allowlist-file and skip-kernel-splat-check provide an escape hatch for known-benign matches. Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Mykyta Yatsenko <yatsenko@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-fatal splat (WARN, KASAN report, lockdep, hung task) leaves the VM running, so the selftest binary still exits 0 and CI goes green on a kernel that just hit a real bug. We have no signal for these today.
Scan dmesg after the run and add a kernel_splats row to the existing exitstatus aggregator. A scan that cannot run fails the row rather than reporting clean, otherwise a typo in a pattern file would quietly turn the check off. splat-allowlist-file and skip-kernel-splat-check provide an escape hatch for known-benign matches.