perf: compact initial TailHTML fixups - #388
Merged
Merged
Conversation
Emit block-scoped DOM helpers once per non-empty tail and pass numeric Jids with raw operation payloads. Preserve TailHTML lifecycle behavior while matching the WebSocket DOM operations and fixing newline handling for remove/class messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #387
Summary
A/R/C/Dhelpers used by each initial tailjid.PrefixSAttrsplits at its first newlineidguardAll non-empty tails use the alias form. One
SClass("cls")fixup grows from 89 to 146 bytes; six comparable class fixups shrink from 534 to 201 bytes.Measurements
Compared with
origin/mainusing six one-second samples per version andbenchstat. The timed loop includes queue refill and one-shot reset.Verification
go generate ./...go vet ./...gofmt -l .staticcheck ./...golangci-lint rungosec ./...go build ./...GOOS=linux GOARCH=386 CGO_ENABLED=0 go build ./...JAWS_REQUIRE_NODE=1 go test -race ./...JAWS_REQUIRE_NODE=1 go test ./...