Skip to content

TPT-3719: Fixed bug causing deeply nested object lists to be improperly displayed - #925

Merged
ezilber-akamai merged 8 commits into
linode:devfrom
ezilber-akamai:TPT-3719-fix-help-output-for-nested-object-array
Sep 17, 2026
Merged

ezilber-akamai merged 8 commits into
linode:devfrom
ezilber-akamai:TPT-3719-fix-help-output-for-nested-object-array

Conversation

@ezilber-akamai

@ezilber-akamai ezilber-akamai commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

📝 Description

Output of --help would incorrectly display deeply nested lists of objects. For example,

linode-cli lke cluster-create --help showed

--node_pools.taints (JSON, conflicts with children): 
      --node_pools.taints.effect (required): The Kubernetes taint effect.
      --node_pools.taints.key (required): The Kubernetes taint key.
      --node_pools.taints.value (required): The Kubernetes taint value.

instead of

--node_pools.taints (JSON):

✔️ How to Test

Check out this PR locally and run make install

Then run:
make test-unit
make test-int

@ezilber-akamai
ezilber-akamai requested review from a team as code owners September 11, 2026 18:14
@ezilber-akamai ezilber-akamai added the bugfix for any bug fixes in the changelog. label Sep 11, 2026
@ezilber-akamai
ezilber-akamai requested review from jriddle-linode and mawilk90 and removed request for a team September 11, 2026 18:14
@ezilber-akamai
ezilber-akamai requested a lite review from Copilot and removed request for jriddle-linode and mawilk90 September 11, 2026 18:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ezilber-akamai
ezilber-akamai requested review from a team, mawilk90 and yec-akamai and removed request for a team September 11, 2026 18:37
@mawilk90

mawilk90 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Hi @ezilber-akamai, I can't see any changes (probably after merging dev branch) so do we still need this PR?

@ezilber-akamai

Copy link
Copy Markdown
Contributor Author

Hi @ezilber-akamai, I can't see any changes (probably after merging dev branch) so do we still need this PR?

Oh it must have been fixed elsewhere. Yeah looks like we can close this PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The baked-module guide must document the new JSON-only exception, and a changed comment has a grammatical error.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (1)

linodecli/baked/request.py:190

  • This changes the blanket behavior documented in linodecli/baked/AGENTS.md:19 (arrays of objects get a parent JSON argument and child dot-path arguments), while that guide explicitly requires behavior changes to be documented (linodecli/baked/AGENTS.md:8). Please update the guide to record that arrays of objects already nested under a list are JSON-only and are not expanded.
        # NOTE: We only expand an array of objects into individual child
        # arguments when it is not already nested under another list
        # (i.e. parent is None). The CLI can only associate one level of
        # nested list objects, so a list of objects nested within another
        # list must be treated as JSON instead.
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread linodecli/baked/request.py Outdated
@ezilber-akamai
ezilber-akamai merged commit dea006e into linode:dev Sep 17, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix for any bug fixes in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants