TPT-3719: Fixed bug causing deeply nested object lists to be improperly displayed - #925
Conversation
…ed in --help output
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Hi @ezilber-akamai, I can't see any changes (probably after merging dev branch) so do we still need this PR? |
Oh it must have been fixed elsewhere. Yeah looks like we can close this PR. |
There was a problem hiding this comment.
🟡 Changes recommended
The baked-module guide must document the new JSON-only exception, and a changed comment has a grammatical error.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (1)
linodecli/baked/request.py:190
- This changes the blanket behavior documented in
linodecli/baked/AGENTS.md:19(arrays of objects get a parent JSON argument and child dot-path arguments), while that guide explicitly requires behavior changes to be documented (linodecli/baked/AGENTS.md:8). Please update the guide to record that arrays of objects already nested under a list are JSON-only and are not expanded.
# NOTE: We only expand an array of objects into individual child
# arguments when it is not already nested under another list
# (i.e. parent is None). The CLI can only associate one level of
# nested list objects, so a list of objects nested within another
# list must be treated as JSON instead.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
📝 Description
Output of
--helpwould incorrectly display deeply nested lists of objects. For example,linode-cli lke cluster-create --helpshowedinstead of
✔️ How to Test
Check out this PR locally and run
make installThen run:
make test-unitmake test-int