[breaking] [deprecation] Remove Cilium BGP load balancer support - #602
Open
moshevayner wants to merge 1 commit into
Open
[breaking] [deprecation] Remove Cilium BGP load balancer support#602moshevayner wants to merge 1 commit into
moshevayner wants to merge 1 commit into
Conversation
Signed-off-by: Moshe Vayner <moshe@vayner.me>
moshevayner
commented
Jul 31, 2026
Comment on lines
+19
to
+34
| func createTestService() *v1.Service { | ||
| return &v1.Service{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: randString(), | ||
| Namespace: "test-ns", | ||
| UID: "foobar123", | ||
| }, | ||
| Spec: v1.ServiceSpec{ | ||
| Ports: []v1.ServicePort{ | ||
| {Name: randString(), Protocol: "TCP", Port: 80, NodePort: 30000}, | ||
| {Name: randString(), Protocol: "TCP", Port: 8080, NodePort: 30001}, | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
This helper previously existed in cilium_loadbalancers_test.go but is used by other tests as well, so I moved it into this file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
+ Coverage 73.76% 75.14% +1.38%
==========================================
Files 19 18 -1
Lines 3045 2672 -373
==========================================
- Hits 2246 2008 -238
+ Misses 538 453 -85
+ Partials 261 211 -50 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
moshevayner
changed the title
moshevayner
marked this pull request as ready for review
July 31, 2026 21:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Moshe Vayner moshe@vayner.me
Summary
Removes Cilium BGP load-balancer support from the CCM.
--load-balancer-type=nodebalancerfor existing deployment compatibility.Deprecation / Breaking Change
--load-balancer-type=cilium-bgpis no longer supported.Clusters using Cilium BGP shared-IP load balancing must migrate to NodeBalancers, including Premium NodeBalancers where higher capacity is required.
Validation
mise run codegengo test ./...helm lint deploy/charthelm template ccm deploy/chartGeneral:
Pull Request Guidelines: