DPS-45125: ACLP Logs - add new TrafficPeak destination type - #737
Open
mduda-akamai wants to merge 1 commit into
Open
mduda-akamai wants to merge 1 commit into
mduda-akamai wants to merge 1 commit into
Conversation
mduda-akamai
requested review from
psnoch-akamai and
yec-akamai
and removed request for
a team
September 3, 2026 09:01
mduda-akamai
changed the title
mduda-akamai
changed the title
mduda-akamai
force-pushed
the
feat/DPS-45125-ACLP-Logs-add-new-TrafficPeak-destination-type
branch
from
September 14, 2026 12:57
31791b0 to
bd298eb
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The TrafficPeak stream integration test remains skipped unless an additional undocumented flag is enabled.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds SDK support for TrafficPeak ACLP log destinations.
Changes:
- Adds TrafficPeak destination models, serialization, and creation support.
- Adds unit fixtures and unit/integration tests.
- Adds workflow controls for TrafficPeak integration tests.
File summaries
| File | Description |
|---|---|
linode_api4/objects/monitor.py |
Defines and deserializes TrafficPeak destinations. |
linode_api4/groups/monitor.py |
Supports TrafficPeak destination creation. |
test/unit/objects/monitor_test.py |
Tests serialization and loading. |
test/integration/models/monitor/test_monitor_logs.py |
Adds gated live API coverage. |
test/fixtures/monitor_streams_destinations_3.json |
Provides a destination fixture. |
test/fixtures/monitor_streams_4.json |
Provides a stream fixture. |
.github/workflows/e2e-test.yml |
Adds the TrafficPeak test input. |
.github/workflows/e2e-test-pr.yml |
Adds the TrafficPeak PR test input. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add support for a new destination type: TrafficPeak in ACLP Logs
Note: The TrafficPeak destination is not yet supported in Linode's APIv4. I'll merge this PR once it's implemented there.
✔️ How to Test
Unit tests:
make test-unitIntegration tests:
Note: The TrafficPeak destination is not yet supported in Linode's APIv4, so the TrafficPeak integration tests are disabled for now with the RUN_TRAFFIC_PEAK_TESTS flag by default.
export LINODE_TOKEN="YOUR_REAL_TOKEN"export RUN_TRAFFIC_PEAK_TESTS=truemake TEST_SUITE="monitor/test_monitor_logs.py" test-int