nvme: move submit_io to src/io-cmds - #3791
Conversation
|
Good idea! The [28](https://github.com/linux-nvme/nvme-cli/actions/runs/31263410067/job/93117592364?pr=3791#step:5:229)
../src/io-cmds.c: In function 'submit_io':
../src/io-cmds.c:190:49: error: implicit declaration of function 'basename' [-Wimplicit-function-declaration]
190 | basename(argv[optind]));
| ^~~~~~~~There is |
|
One thing we need to figure out is how to split up the plugin registry. Currently, it needs to be in |
|
Just fixed the warning by including |
This is to move other IO commands as same. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
This is to use a global function for the command entry. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
|
Just pushed the commits to fix and update the commit and add a commit to add GL_ENT macro then the IO command functions can be used as a global function. |
This is to split the big file nvme.c. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
|
Didn't have time to look into this PR. Next week, sorry about that. |
|
No problem. Thank you. |
This is to move other IO commands as same.