doc/reproducible-builds.md: fix verification section - #2178
Closed
tlaurion wants to merge 1 commit into
Closed
Conversation
…erification Remove stale claim that warm builds produce partial hashes.txt (FORCE on modules.cpio ensures completeness). Separate verification into Same commit (everything should match) and Different commits (ROM always differs due to GIT_HASH in /etc/config). Drop real.gitclean_keep_packages reference. Signed-off-by: Thierry Laurion <insurgo@riseup.net>
There was a problem hiding this comment.
🟡 Not ready to approve
The “step down” troubleshooting guidance for same-commit ROM mismatches omits checking bzImage, which can misdirect investigations when the kernel image is the differing artifact.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Updates the reproducible-builds documentation to correct the ROM reproducibility verification guidance, aligning it with current build behavior and separating same-commit vs different-commit expectations.
Changes:
- Removes the stale
real.gitclean_keep_packagesreference and the incorrect “warm builds produce partial hashes.txt” claim. - Splits verification guidance into Same commit (ROM hash should match) vs Different commits (ROM hash expected to differ due to embedded
GIT_HASH).
File summaries
| File | Description |
|---|---|
| doc/reproducible-builds.md | Fixes and clarifies the ROM reproducibility verification section (same-commit vs different-commit), and removes outdated/incorrect prerequisites. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Comment on lines
+148
to
+151
| If the ROM differs, step down: `initrd.cpio.xz` → `tools.cpio` → | ||
| individual files. The innermost differing file (e.g. `./bin/busybox`) is the | ||
| root cause — fix it and the cascade resolves. `hashes.txt` records every file | ||
| at every level, so no diffoscope is needed until you've identified what differs. | ||
| at every level so no diffoscope is needed until you've identified what differs. |
tlaurion
added a commit
to tlaurion/heads
that referenced
this pull request
Aug 6, 2026
Supersedes linuxboot#2178. - Rewrite real.gitclean / gitclean_keep_packages / gitclean_keep_packages_and_build @echo messages to name the git clean -fxd command and describe exact preserve rules - Tighten real.remove_canary_files-extract_patch_rebuild_what_changed @echo messages: make clear that this target deletes .canary stamps and the re-extract/rebuild happens on the next make invocation - Split reproducibility doc verification into Same/Different commit sections - Remove stale warm-build partial-hashes.txt claim (FORCE fixes make it obsolete) - Add CI hashes.txt download reference with example URL - Add clean working tree prerequisite - Simplify comprehensive diff command (hash+path comparison, drop awk) - Restore bzImage in step-down path - Fix SOURCE_DATE_EPOCH claim: always 0 (extracted tarballs lack .git; git log in modules/musl-cross-make falls back to echo 0) Signed-off-by: Thierry Laurion <insurgo@riseup.net>
tlaurion
added a commit
to tlaurion/heads
that referenced
this pull request
Aug 7, 2026
Supersedes linuxboot#2178. - Rewrite real.gitclean / gitclean_keep_packages / gitclean_keep_packages_and_build @echo messages to name the git clean -fxd command and describe exact preserve rules - Tighten real.remove_canary_files-extract_patch_rebuild_what_changed @echo messages: make clear that this target deletes .canary stamps and the re-extract/rebuild happens on the next make invocation - Split reproducibility doc verification into Same/Different commit sections - Remove stale warm-build partial-hashes.txt claim (FORCE fixes make it obsolete) - Add CI hashes.txt download reference with example URL - Add clean working tree prerequisite - Simplify comprehensive diff command (hash+path comparison, drop awk) - Restore bzImage in step-down path - Fix SOURCE_DATE_EPOCH claim: always 0 (extracted tarballs lack .git; git log in modules/musl-cross-make falls back to echo 0) Signed-off-by: Thierry Laurion <insurgo@riseup.net>
tlaurion
added a commit
to tlaurion/heads
that referenced
this pull request
Aug 7, 2026
Supersedes linuxboot#2178. - Rewrite real.gitclean / gitclean_keep_packages / gitclean_keep_packages_and_build @echo messages to name the git clean -fxd command and describe exact preserve rules - Tighten real.remove_canary_files-extract_patch_rebuild_what_changed @echo messages: make clear that this target deletes .canary stamps and the re-extract/rebuild happens on the next make invocation - Split reproducibility doc verification into Same/Different commit sections - Remove stale warm-build partial-hashes.txt claim (FORCE fixes make it obsolete) - Add CI hashes.txt download reference with example URL - Add clean working tree prerequisite - Simplify comprehensive diff command (hash+path comparison, drop awk) - Restore bzImage in step-down path - Fix SOURCE_DATE_EPOCH claim: always 0 (extracted tarballs lack .git; git log in modules/musl-cross-make falls back to echo 0) Signed-off-by: Thierry Laurion <insurgo@riseup.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reproducibility doc that landed via #2174 has three issues:
real.gitclean_keep_packageswhich was renamed toreal.gitclean_keep_pkgin the Makefile reorg.This fix separates Same commit (everything should match) from Different commits (ROM always differs), removes the stale target reference, and drops the incorrect warm-build claim.