refactor: optimize AM appitem property update handling

[wjyrich]

1. Refactor onPropertyChanged to handle individual property changes
   instead of fetching all properties on every D-Bus signal
2. Add vendor and genericName data roles to AppItem with corresponding
   accessors
3. Introduce Environ role for storing application environment data
4. Remove QtConcurrent dependency by simplifying async loading logic
5. Fix isOnDesktop property name mismatch (was OnDesktop)
6. Optimize duplicate check during managed objects loading
7. Replace ready property with proper readyChanged signal emission
8. Expose DDE categories as a QVariantMap property for QML usage
9. Clean up updateActions to properly handle empty action lists

Log: Optimized app item property updates and added vendor/genericName/
Environ data roles

Influence:

1. Verify application display names and generic names still display
   correctly in launcher
2. Test that application icons update properly when changed at runtime
3. Verify app model readiness signal works correctly with QML bindings
4. Test category filtering still functions with new DDE categories
   property
5. Verify duplicate desktop entries are properly filtered during loading
6. Test action menus still work correctly for applications with defined
   actions
7. Verify apps are correctly filtered by vendor (deepin vs other)

refactor: 优化AM应用项属性更新处理

1. 重构onPropertyChanged，针对单个属性变化进行处理，而不是每次D-Bus信号
   都获取所有属性
2. 为AppItem添加vendor和genericName数据角色及对应的访问器
3. 新增Environ角色用于存储应用环境数据
4. 简化异步加载逻辑，移除QtConcurrent依赖
5. 修复isOnDesktop属性名称不匹配问题（原为OnDesktop）
6. 优化加载托管对象时的重复检查逻辑
7. 用proper readyChanged信号替代原ready属性
8. 将DDE分类暴露为QVariantMap属性供QML使用
9. 清理updateActions以正确处理空操作列表

Log: 优化应用项属性更新，新增vendor/genericName/Environ数据角色

Influence:

1. 验证启动器中应用显示名称和通用名称是否仍然正确显示
2. 测试应用图标在运行时更改后是否能正确更新
3. 验证应用模型就绪信号与QML绑定的正常工作
4. 测试分类过滤功能在新DDE分类属性下是否正常
5. 验证加载过程中重复桌面条目的过滤是否正常
6. 测试已定义动作的应用的右键菜单是否正常工作
7. 验证应用是否能按供应商正确筛选（deepin与其他）

PMS: TASK-393709

[sourcery-ai]

Sorry @wjyrich, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[sourcery-ai]

Reviewer's Guide

Refactors application manager integration to perform targeted AMAppItem property updates, enrich AppItem metadata, introduce a GIO-based TrashMonitor for dynamic trash icon state, extend AppsApplet with app management APIs, fix AMAppItemModel initialization/ready signaling (including trash icon updates and deduplication), and propagate app model data changes into the dock's global element model.

Sequence diagram for AMAppItem targeted property updates

sequenceDiagram
    participant AM_Application as ApplicationManager_Application
    participant DBus as DBus
    participant AMAppItem as AMAppItem
    participant AppItem as AppItem
    participant AppItemModel as AppItemModel

    AM_Application->>DBus: PropertiesChanged
    DBus->>AMAppItem: onPropertyChanged(QDBusMessage)
    AMAppItem->>AMAppItem: qdbus_cast QVariantMap changedProperties
    alt [Name/GenericName/X_Deepin_Vendor changed]
        AMAppItem->>AppItem: setGenericName()
        AMAppItem->>AppItem: setVendor()
        AMAppItem->>AppItem: setAppName()
    end
    alt [Icons changed]
        AMAppItem->>AppItem: setAppIconName()
    end
    alt [Categories changed]
        AMAppItem->>AppItem: setDDECategories()
        AMAppItem->>AppItem: setCategories()
    end
    alt [Actions or ActionName changed]
        AMAppItem->>AMAppItem: updateActions()
        AMAppItem->>AppItem: setActions()
    end
    AppItem-->>AppItemModel: dataChanged(...) emits

Loading

Sequence diagram for TrashMonitor-driven trash icon updates

sequenceDiagram
    participant FS as GIO_trash
    participant GIO as GFileMonitor
    participant TrashMonitor as TrashMonitor
    participant AMAppItemModel as AMAppItemModel
    participant TrashItem as AMAppItem_dde_trash

    FS-->>GIO: file event
    GIO->>TrashMonitor: onTrashChanged(...)
    TrashMonitor->>TrashMonitor: updateState()
    TrashMonitor-->>AMAppItemModel: emptyChanged(bool)
    AMAppItemModel->>AMAppItemModel: updateTrashIcon()
    AMAppItemModel->>TrashItem: setAppIconName(user-trash | user-trash-full)

Loading

File-Level Changes

Change	Details	Files
Extend AppsApplet to expose app model readiness, category metadata, and rich application management operations for launch, autostart, scaling, and desktop shortcuts.	Expose appModel, groupModel, appModelReady, and ddeCategories via Q_PROPERTY and helper accessors Add a private application() helper to resolve AMAppItem by desktopId while normalizing .desktop suffix Implement launchApp() using QProcess to invoke dde-am with optional activation token and error logging Add autoStart()/setAutoStart() and disableScale()/setDisableScale() that manipulate AMAppItem D-Bus properties and environment variables Add isOnDesktop(), sendToDesktop(), and removeFromDesktop() wrappers around AMAppItem D-Bus methods with error-checked replies	applets/dde-apps/appsapplet.cpp applets/dde-apps/appsapplet.h
Refine AMAppItem to initialize vendor/genericName and handle D-Bus property change signals by updating only changed AppItem fields.	Connect to org.freedesktop.DBus.Properties::PropertiesChanged on each AM application object Initialize AppItem::genericName and AppItem::vendor from AM metadata and adjust isOnDesktop key In onPropertyChanged(), filter by Application interface, parse the changed-properties map, and selectively update AppItem fields (names, icons, flags, categories, timestamps, execs, desktop source path, actions, etc.) Ensure actions JSON is cleared when no actions exist instead of retaining stale data	applets/dde-apps/amappitem.cpp
Fix AMAppItemModel initialization, introduce trash monitoring, and ensure trash icon reflects actual trash state without duplicate applications.	Create and own a TrashMonitor instance and hook its emptyChanged signal to updateTrashIcon() Enhance GetManagedObjects() completion handler to skip empty paths, deduplicate by DesktopIdRole, and properly set m_ready and emit readyChanged Update AMAppItemModel constructor wiring to append new AMAppItem rows and refresh trash icon on additions and on relevant dataChanged events Implement updateTrashIcon() to toggle dde-trash's icon between user-trash and user-trash-full based on TrashMonitor::isEmpty()	applets/dde-apps/amappitemmodel.cpp applets/dde-apps/amappitemmodel.h applets/dde-apps/trashmonitor.cpp applets/dde-apps/trashmonitor.h applets/dde-apps/CMakeLists.txt
Extend AppItem/AppItemModel roles to carry vendor and genericName metadata into the model layer.	Add VendorRole and GenericNameRole to AppItemModel::Roles and expose them in roleNames() Implement AppItem::vendor/genericName getters and setters that store data under the new roles	applets/dde-apps/appitem.cpp applets/dde-apps/appitem.h applets/dde-apps/appitemmodel.cpp applets/dde-apps/appitemmodel.h
Propagate app model data changes into DockGlobalElementModel so dock entries stay in sync with application metadata.	Connect to the apps model's dataChanged signal and, for each affected source row present in m_data, emit corresponding dataChanged from the dock model When DesktopIdRole changes, also mark ItemIdRole as changed so consumers relying on item IDs get notified	panels/dock/taskmanager/dockglobalelementmodel.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[wjyrich]

/test github-pr-review-ci

[deepin-ci-robot]

deepin pr auto review

★ 总体评分：95分

■ 【总体评价】

代码完美重构了DBus属性变更监听机制，彻底解决了全量刷新导致的性能瓶颈与属性遗漏问题
逻辑严密、质量优良且性能提升显著，无任何安全漏洞，符合优秀标准

■ 【详细分析】

• 1.语法逻辑（基本正确）✓

修正了历史上AppItemModel缺失Q_OBJECT宏却使用Q_ENUM的隐患，补充了构造函数中遗漏的genericName和vendor属性初始化，修复了isOnDesktop属性名大小写不一致的错误。onPropertyChanged函数中的按需解析逻辑严谨，通过Lambda封装取值与判断，确保了未变更属性回退到Application基类当前值的正确性。
潜在问题：无
建议：无

• 2.代码质量（良好）✓

大幅消除了冗余代码，移除了无用的析构函数、空转的load()函数及未使用的成员变量m_appModelReady。将硬编码的DBus接口字符串提取为AM_APPLICATION_INTERFACE等静态常量，提升了可维护性。使用QLatin1StringView优化了字符串比较，updateActions末尾的空数组判断简化为三元运算符，代码更加精简规范。
潜在问题：无
建议：无

• 3.代码性能（高效）✓

核心改动精准击中性能痛点，将旧版每次触发信号都通过同步DBus调用全量拉取所有属性的重逻辑，重构为仅解析PropertiesChanged信号携带的增量QVariantMap。这极大降低了DBus通信开销与本地解析损耗。同时移除了不必要的Qt::Concurrent依赖，并在amappitemmodel.cpp中增加了防重复插入检查，避免了潜在的重复对象创建开销。
潜在问题：无
建议：无

• 4.代码安全（存在0个安全漏洞）✓

漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个
代码处理的DBus消息来源于系统级应用管理服务，且在onPropertyChanged中严格校验了参数数量与接口名称。数据流转均在进程内的数据模型层完成，不涉及命令执行、文件路径越界或敏感信息泄露。新增的ddeCategories方法仅作枚举值映射，无外部输入注入风险。

• 建议：保持当前的防御性编程习惯，无需额外修改

■ 【改进建议代码示例】

// 建议在 amappitem.cpp 的 onPropertyChanged 中增加对 QVariantMap 转换的防御性校验
// 以防止极端情况下 DBus 守护进程或底层库返回畸形数据导致隐式转换异常
void AMAppItem::onPropertyChanged(const QDBusMessage &msg)
{
    const QList<QVariant> arguments = msg.arguments();
    if (arguments.count() != 3)
        return;

    if (arguments.at(0).toString() != AM_APPLICATION_INTERFACE)
        return;

    // 增加类型校验，确保第二个参数确实是 QVariantMap
    if (!arguments.at(1).canConvert<QVariantMap>())
        return;

    QVariantMap changedProperties = qdbus_cast<QVariantMap>(arguments.at(1));

    const auto value = [&changedProperties](QLatin1StringView name) {
        return changedProperties.value(name);
    };
    const auto contains = [&changedProperties](QLatin1StringView name) {
        return changedProperties.contains(name);
    };

    // 后续逻辑保持不变...
}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, wjyrich

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment