Skip to content

rebase to 3.24, compile on edge - #106

Merged
aptalca merged 1 commit into
masterfrom
3.24
Sep 10, 2026
Merged

aptalca merged 1 commit into
masterfrom
3.24

Conversation

@aptalca

@aptalca aptalca commented Sep 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@aptalca
aptalca requested a review from a team September 10, 2026 12:36
@LinuxServer-CI LinuxServer-CI moved this to PRs Ready For Team Review in Issue & PR Tracker Sep 10, 2026
@LinuxServer-CI

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR for commit af7a50d :
https://ci-tests.linuxserver.io/lspipepr/syncthing/v2.1.5-pkg-91c54fca-dev-af7a50d88eb8c656360e86624d67ad7ca231ebc0-pr-106/index.html
https://ci-tests.linuxserver.io/lspipepr/syncthing/v2.1.5-pkg-91c54fca-dev-af7a50d88eb8c656360e86624d67ad7ca231ebc0-pr-106/shellcheck-result.xml

Tag Passed
amd64-v2.1.5-pkg-91c54fca-dev-af7a50d88eb8c656360e86624d67ad7ca231ebc0-pr-106
arm64v8-v2.1.5-pkg-91c54fca-dev-af7a50d88eb8c656360e86624d67ad7ca231ebc0-pr-106

@thelamer thelamer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now, do your forsee any issues with edge bins in 3.24 runtime? Or is go portable enough does not matter ?

@github-project-automation github-project-automation Bot moved this from PRs Ready For Team Review to PRs Approved in Issue & PR Tracker Sep 10, 2026
@aptalca

aptalca commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

I think go is portable enough. It's a static binary that can technically run in a scratch image. And the compile deps are mainly go and other boilerplate stuff.

I'm pretty sure we did this for another go app where we build on edge and transfer to stable. That way we don't have to worry about the upstream pinning their minimum go version to the latest shortly after release.

@aptalca
aptalca merged commit 9a670c5 into master Sep 10, 2026
5 of 8 checks passed
@aptalca
aptalca deleted the 3.24 branch September 10, 2026 15:11
@LinuxServer-CI LinuxServer-CI moved this from PRs Approved to Done in Issue & PR Tracker Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants