Change Unity CI license logic - #384
Merged
Merged
Conversation
This reverts commit 0785b5d.
MaxHeimbrock
marked this pull request as ready for review
September 9, 2026 14:00
MaxHeimbrock
requested review from
cloudwebrtc,
ladvoc and
xianshijing-lk
as code owners
September 9, 2026 14:00
cloudwebrtc
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The CI was using a
UNITY_LICENSEfrom our CI secrets. Recently that license was not working anymore, but we can just use the already preparedUNITY_EMAILandUNITY_PASSWORDto authenticate. Without the license variable set, the fallback already works.Verification
The first test commit fails both Unity test runs because of the license, then the fix to the CI script fixes the pipeline.
Follow up
Delete the license secret.