Guard the sync engine against out-of-domain sender reports - #983
Open
frostbyte73 wants to merge 3 commits into
Open
Guard the sync engine against out-of-domain sender reports#983frostbyte73 wants to merge 3 commits into
frostbyte73 wants to merge 3 commits into
Conversation
The new egress sync engine rejects RTCP sender reports whose RTP timestamps are not in the same domain as the track's media stream, GetSessionPTS no longer returns a value it has flagged as abnormal, and the abnormal-result warn is rate-limited
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sender reports that arrive before a track's first media packet bypass the RTP domain guard, which stays disarmed until lastTS exists. Four of them are enough to build a ready regression on the wrong domain, and once the guard arms it rejects the very sender reports whose outliers would otherwise have forced a rebuild.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The guard's tests passed unchanged at any threshold from 1s to 30s, so a retune would not have been caught. In-domain probes now sit at a 4s gap and a new table row is rejected only below 7s, bounding the value to [4s, 7s). Also drops an unreachable zero-time fallback whose only caller always passes a real timestamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new egress sync engine rejects RTCP sender reports whose RTP timestamps are not in the same domain as the track's media stream, GetSessionPTS no longer returns a value it has flagged as abnormal, and the abnormal-result warn is rate-limited