Ensure that transfer requests are properly authorized. - #797
Open
alexfish8 wants to merge 1 commit into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+507
to
+511
| if req.GetRoomName() == "" && req.GetParticipantIdentity() == "" { | ||
| // Skip performing this authorization check against older clients. | ||
| // TODO: Remove this branch after clients have been updated to set these fields. | ||
| return nil | ||
| } |
There was a problem hiding this comment.
🟨 Transfer authorization is skipped entirely when the request omits room and participant
The new authorization check in pkg/sip/service.go:507-511 bypasses validation whenever both RoomName and ParticipantIdentity are empty in the transfer request, so any caller able to reach the internal transfer RPC can still transfer an arbitrary call by simply omitting those two fields. This is an intentional backwards-compatibility branch (documented with a TODO), but it means the control provides no protection until it is enforced.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs: