feat(frontends): extend ACP bridge for Agentero integration - #788
Open
Phil-Fan wants to merge 2 commits into
Open
feat(frontends): extend ACP bridge for Agentero integration#788Phil-Fan wants to merge 2 commits into
Phil-Fan wants to merge 2 commits into
Conversation
…istence, terminal and embeddedContext - Add session/list, session/load, session/resume, session/delete lifecycle methods - Persist session metadata and conversation history to temp/acp_sessions/ - Add terminal/* methods (create/output/wait/kill/release) via subprocess - Support embeddedContext/resource content blocks in prompts - Stream agent_message_chunk with required messageId - Remove auth, audio, image and MCP support per project policy
- Test initialize capability advertisement - Test session lifecycle (new/list/load/resume/delete) - Test terminal lifecycle - Test prompt builder resource/embeddedContext handling and media omission - Test streaming chunk includes messageId
Author
usage screenshot in Agentero |
Phil-Fan
marked this pull request as ready for review
September 2, 2026 04:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the experimental ACP stdio bridge in
frontends/genericagent_acp_bridge.pyso that GenericAgent can be used as an ACP agent inside editors/clients such as Agentero.The bridge already spoke a minimal subset of the Agent Client Protocol (ACP). This change fills in the remaining baseline capabilities Agentero's BYOA ACP client needs in order to drive GenericAgent as a first-class coding assistant.
Motivation
Agentero connects to local agents via ACP. The existing bridge only handled
initialize,session/new,session/promptandsession/cancel, which meant Agentero could start a turn but could not:messageIdboundaries,This PR completes those baseline ACP capabilities while keeping image, audio and MCP support intentionally disabled.
What changed
session/list,session/load,session/resume,session/deleteandsession/close.temp/acp_sessions/so a restarted bridge can resume previous conversations.terminal/*methods (create,output,wait_for_exit,kill,release) viasubprocess.Popen.resource/resource_link/ embedded context blocks; image and audio blocks are explicitly omitted and reported as disabled in capabilities.agent_message_chunknow carries the requiredmessageIdso clients can reassemble streamed messages.authMethodsis empty andmcpCapabilitiesstays disabled.Tests
Added
frontends/tests/test_acp_bridge_smoke.pywith smoke tests for initialize, session lifecycle, terminal lifecycle, prompt builder behavior, and chunk formatting.Related