feat: add new option for ignored regions - #153
Closed
hongdeyuan wants to merge 7 commits into
Closed
hongdeyuan wants to merge 7 commits into
hongdeyuan wants to merge 7 commits into
Conversation
|
Looks great! |
Venefilyn
added a commit
to Venefilyn/pixelmatch
that referenced
this pull request
Sep 8, 2026
New check where if a value from `ignoreMask` is greater than 0 it will be ignored from the check. The ignore mask itself needs to be exact width and height of the images provided. One could write an array manually or provide a PNG image with RGBA(0,0,0,0) for pixels to check and any other color value for what to skip. Fixes: mapbox#163 Supercedes: mapbox#153 Signed-off-by: Freya Gustavsson <freya@venefilyn.se>
Member
|
Closing in favor of #171 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I personally think that 「ignored regions」 is a great feature; I helped resolve the conflict (#122 @rafalszemraj), Can you（@mourner） merge it ?
Help us ignored many factors