MLE-31583 Update npm-publish-packages.yml to use NodeJS 24 - #1124
Merged
Conversation
rjdew-progress
requested review from
RitaChen609,
jonmille,
ngodugu-marklogic and
rjrudin
as code owners
September 9, 2026 17:36
jonmille
approved these changes
Sep 9, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Enabling workflow_dispatch without an explicit guard/confirmation allows manual runs to execute npm publish, increasing the risk of accidental or unintended publishes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the npm package publishing GitHub Actions workflow to run with Node.js 24, and adds a manual trigger option for running the publish workflow.
Changes:
- Bump
actions/setup-nodeconfiguration from Node.js 22 to Node.js 24. - Add
workflow_dispatchso the publish workflow can be triggered manually. - Minor normalization of the
npm publish --registryURL.
File summaries
| File | Description |
|---|---|
| .github/workflows/npm-publish-packages.yml | Updates the Node.js version used for publishing and adds a manual workflow trigger for publishing. |
Review details
Suppressed comments (1)
.github/workflows/npm-publish-packages.yml:28
- With
workflow_dispatchenabled,npm publishwill run on manual invocations as well. Add a step-levelif:guard so publishing only occurs on release events unless the manual input explicitly confirms publishing.
- run: npm publish --registry=https://registry.npmjs.org # Or: npm stage publish
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| on: | ||
| release: | ||
| types: [published] | ||
| workflow_dispatch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.