MLE-31583 explicitly run prepublishOnly to generate SBOM - #1125
Merged
Conversation
rjdew-progress
requested review from
RitaChen609,
jonmille,
ngodugu-marklogic and
rjrudin
as code owners
September 9, 2026 20:16
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The workflow’s new publish input is not enforced and prepublishOnly would be executed twice during npm publish unless the publish step is adjusted.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the npm publish GitHub Actions workflow to support SBOM generation via an explicit prepublishOnly run, and adds a manual dispatch input intended to control publishing.
Changes:
- Added a
workflow_dispatchboolean input (publish) intended to toggle whether a manual run publishes to npm. - Explicitly runs
npm run prepublishOnlybefore publishing (to generate SBOM as part of the publish pipeline).
File summaries
| File | Description |
|---|---|
| .github/workflows/npm-publish-packages.yml | Adds workflow_dispatch input and runs prepublishOnly during the publish workflow. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - run: npm run test:types | ||
| - run: npm run prepublishOnly | ||
| # TODO: Create a way to run non-integration tests that don't rely on a MarkLogic Server instance | ||
| - run: npm publish --registry=https://registry.npmjs.org # Or: npm stage publish |
Contributor
Author
There was a problem hiding this comment.
scripts are disabled in the .npmrc file.
jonmille
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.