fix: expose complete static DataSet inventory and diagnostics - #182
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ARSAS could still hide Siemens static DataSet members such as cross-LDevice GGIO object-level FCD entries because the SCL engine projection used a different reference identity from the live DataObject model. Existing synthetic tests did not exercise the actual SCL parser/projection path.
Engine dependency
Pins ARIEC61850 main at
4fc3119be2bb97e0ea3a8d31fb990e6a1a089e60(PR #77), which canonicalizes parser FCDA references such asIED/LD/GGIO6.CBOpnd [ST]to the live-model identityIEDLD/GGIO6.CBOpnd, while keeping FC separately and never inventing.stValfor object-level FCD members.ARSAS changes
Application/LLN0DataSet targetingADD/GGIO6.[ST]suffix or fabricated.stVal.This is intended to make the Siemens CID failure directly observable: a healthy import should show the full static inventory represented, and any gap now prints the missing DataSet/member reference.