fix: recover offline static DataSet members in Signal Selection - #183
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Field validation on Siemens CID
AA1C1F13R4showed ARIEC parsed 2 static DataSets / 58 FCDA members, but ARSAS reportedSignal Selection: 0/58 represented.The Signal Selection recovery path only used
LiveDiscoveryModel. For an offline SCL/CID workspace that model is intentionally null, so recovery returned empty even thoughSclWorkspace.DesignModelwas authoritative and complete. Newly recovered rows could also have their static FCDADisplayReferenceoverwritten from the runtimeObjectReference.Fix
LiveDiscoveryModel ?? SclWorkspace.DesignModelas DataSet authority for device-level recoveryDisplayReferencein Signal SelectionMandatory inventorypresentation toSemantic descriptorsso descriptor count is not confused with FCDA member countException.ToString()for dispatcher UI errors soSequence contains more than one elementincludes stack traceExpected field result
For the supplied Siemens CID, after opening Signal Selection the completeness report should move from
0/58toward58/58if all 58 engine-owned static member identities are successfully recovered. No.stValis invented for unresolved object-level FCD members.Physical IED validation is still required after merge; CI only validates the software regression contracts.