Break circular dependency - #128
Open
tacaswell wants to merge 4 commits into
Open
Conversation
mpl-sphinx-theme does not use Matplotlib, but we use ourselves in the docs.
Assisted-by: opeencode:sonnet-4.6 I regret using the robot here.
QuLogic
reviewed
Jul 31, 2026
|
|
||
|
|
||
| [tool.pixi.package] | ||
| version = "3.11.1.dev0" |
Member
There was a problem hiding this comment.
Is that right? We're probably going to forget updating this without documentation, especially if you need the micro.
Member
Author
There was a problem hiding this comment.
dynamic versioning in pixi-build is still not working so I'm not sure what we want to do here.
5ffhb27r6p-max
approved these changes
Aug 1, 2026
Member
|
Seems like there is not much traction on dynamic versions in pixi-build: prefix-dev/pixi#2946 I suppose we can live with manual version bumps, assuming it only matters when we cut a release. Still at least a comment would be helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mpl-sphinx-theme depends on matplotlib which makes setting up the dev environment with pixi annoying.
mpl-sphinx-theme does not actually use Matplotlib, but the docs do.
While I was touching this I moved to PEP 735 dependency groups. I used the robot to write the pip syntax for me and check that I got all the references doc/requirements (I regret this).
This also add the pixi build meta-data so we can directly install this via pixi on Matplotlib.