Remove nine test files whose subject no longer exists - #149
Merged
Conversation
Each imports a module that is absent from this tree and from the public mirror,
at module scope and unguarded, so every test in them errors on import and none
has been able to run:
test_matrixark_scale_topology_bootstrap run_matrixark_rust_scale_report
test_temporalstore_feature_execution_validator validate_temporalstore_rust_feature_execution
test_temporalstore_goal_parity_status validate_temporalstore_rust_goal_parity
test_temporalstore_next_performance_plan_validator audit_temporalstore_rust_performance_artifacts
test_temporalstore_performance_artifact_audit audit_temporalstore_rust_performance_artifacts
test_temporalstore_performance_execution_redaction validate_temporalstore_rust_performance_parity
test_temporalstore_performance_parity_validator validate_temporalstore_rust_performance_parity
The modules are not recoverable: they appear nowhere in either tree and were
never tracked in this history, so there is nothing to restore them from.
Verified before removing -- each file was imported directly and each raised
ModuleNotFoundError naming its missing subject. Suite failing names go 123 -> 117
with no new failures; the one name that shifts,
test_retrieval_audit_is_off_by_default, behaves identically with the deletion
stashed and has moved in and out of the failing set all session.
Two of these filenames also carried a word the push-hygiene rules forbid on any
remote, in a repository that is mirrored publicly. Removing dead files was the
occasion; that they were also a naming violation is a second reason not to leave
them.
test_matrixark_mcp_backend_policy imports the same missing scale-report module but
guards it, so it degrades instead of erroring and is left alone.
Same class as the seven in the parent commit: each imports at module scope a module
that exists in neither this repository nor the private tree.
test_temporalstore_next_performance_workflow run_temporalstore_rust_next_performance_workflow
test_temporalstore_performance_evidence_import import_temporalstore_rust_performance_evidence
Verified by importing each directly; both raise ModuleNotFoundError naming the missing
subject.
bjmeetsfo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nine test files import a module that does not exist in this repository — at module scope and
unguarded, so every test in them errors on import. None of them has ever been able to run.
The modules are not recoverable — absent from this repo and from the private tree, and never
tracked in either history, so there is nothing to restore them from.
Verified before removing: each file was imported directly and each raised
ModuleNotFoundErrornaming its missing subject.test_matrixark_mcp_backend_policyimports the same missing scale-report module but guards it,so it degrades rather than erroring. Left alone.
Effect
Worth knowing
The Python suite is not run by CI —
.github/workflows/has rust-ci, oss-readiness, governanceand auto-approve, and none of them invoke it. That is why nine files that cannot import have
been sitting here unnoticed.
Two of the removed filenames also carried a provenance word this project's push rules disallow
on a public remote. That was not the reason for removing them, but it is a second reason not to
leave them. About twenty other public files still carry it in their names —
tools/run_unified_parity_tests.py,tools/validate_api_model_parity_evidence.py,compat/raft_parity_report_pair_corpus.jsonand similar, with up to eight referencing fileseach. Those are live tooling with importers and shell callers, so renaming them is a separate,
deliberate change rather than something to fold into a deletion PR.