picolibc 1.8.12.3 — the dependency pinned a version that does not exist - #340
Merged
Conversation
A BARE REQUIREMENT IN mcpp IS AN EXACT PIN, NOT A CARET. `1.8.12.2` depended on `llvm.compiler-rt-builtins = "22.1.8"`, written on the belief that a bare requirement is a caret and would match the published `22.1.8.2`. That is true of the matching grammar in `mcpp.version_req` and false of the resolution path: `mcpp::pm::is_version_constraint` returns false for a bare number, so no resolution runs and the literal becomes the wire address. Measured: `Downloading v22.1.8`, then `install path missing after fetch` — xlings resolved and installed the real version while mcpp looked for a directory named after the requirement. Both entries' notes carried the same wrong claim and are corrected. VERIFIED AGAINST THE PUBLISHED INDEX BEFORE TAGGING, which is the step whose absence produced two broken releases today: a consumer built with the new manifest as a path dependency, so that its own edge resolved from the index and nothing else did, reported `compiler-rt-builtins@22.1.8.2, graph` and produced an image that printed through `printf` and exited 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bare requirement in mcpp is an exact pin, not a caret:
is_version_constraintreturns false for a bare number, so"22.1.8"became the wire address and the fetch installed22.1.8.2under a directory mcpp then could not find.Both entries' notes carried the same wrong claim and are corrected. Verified against the published index before tagging.