Add skipCreation to document updates - #993
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe SDK adds ChangesskipCreation document operations
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The new document-operation overloads preserve existing request URLs while sending skipCreation when requested. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 63.16% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
skipCreationoverloads for add/replace and add/update document callsskipCreationquery parameter while preserving existing request URLsTesting
./gradlew test --tests com.meilisearch.sdk.DocumentsSkipCreationTest -x jacocoTestCoverageVerification— passed (3 tests)./gradlew spotlessCheck— passedbash ./scripts/lint.sh— passeddocker compose run --rm -v gradle-cache:/root/.gradle package ./gradlew test— 115/116 passed;SettingsHandlerTestdictionary reset timed outdocker compose run --rm -v gradle-cache:/root/.gradle package ./gradlew test --tests com.meilisearch.sdk.SettingsHandlerTest -x jacocoTestCoverageVerification— passed on immediate rerun (3 tests), confirming the timeout was transientAI-assisted development was used to inspect the existing overload and URL-building patterns, implement the scoped change, and draft focused tests. The final diff and test results were reviewed before submission.
Fixes #919
Summary by CodeRabbit
New Features
Documentation