You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updated e2e script (was pinned to 11.9.1; now 11.12.2)
Skipped (out of scope): dist/, pnpm-lock.yaml
Findings
⚠️ Low — Mismatched indentation in docker-compose.yml command
File:automation/run-e2e/docker/docker-compose.yml line 25 Note: The mxbuild command gained excessive leading whitespace in the diff — it now has far more indentation than the adjacent mx update-widgets line. This is cosmetic but makes the YAML harder to read and may confuse future editors. Fix: Align the mxbuild line with mx update-widgets:
⚠️ Low — tree-node-web e2edev script not updated to match new version
File:packages/pluggableWidgets/tree-node-web/package.json Note: The e2e script was bumped to MENDIX_VERSION=11.12.2 with the new flags, but e2edev still reads MENDIX_VERSION=11.9.1 with no MODERN_CLIENT or ENABLE_RSPACK_BUNDLER. This will cause developers running pnpm e2edev to test against a different runtime than CI, which can mask or create spurious failures. Fix: Update e2edev to match:
"e2edev": "MENDIX_VERSION=11.12.2 MODERN_CLIENT=--modern-web-client ENABLE_RSPACK_BUNDLER=1 run-e2e dev --with-preps"
⚠️ Low — Env vars baked into e2e scripts instead of centralised config
File: All 10 changed package.json files Note:MENDIX_VERSION=11.12.2 MODERN_CLIENT=--modern-web-client ENABLE_RSPACK_BUNDLER=1 is now copy-pasted identically into every e2e script. When the next version bump comes, all 10 files will need to be touched again. The ci.mjs already has a fallback that fetches MENDIX_VERSION from a central version map — consider whether a single source of truth (env file, run-e2e default, or a root-level script) could avoid the duplication. Not blocking, but worth a follow-up issue.
Positives
Both mxbuild.Dockerfile and mxbuildRC.Dockerfile were updated symmetrically — no risk of divergence between stable and RC image builds.
The --modern-client → --modern-web-client rename in ci.mjs (Compose path) is consistent with the existing raw-Docker path in docker-utils.mjs.
Changelog entries are not required — this is a CI/test automation change with no runtime widget behaviour changes.
ENABLE_RSPACK_BUNDLER uses conditional expansion ${ENABLE_RSPACK_BUNDLER:+...} in the Compose YAML, so an unset variable produces no extra whitespace in the mxbuild command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Test related change (New E2E test, test automation, etc.)
Description
This PR updates the used Mendix version to 11.12.2 and, through feature flags, enables React and rspack in the test projects.
What should be covered while testing?
E2E affected should continue to pass in the automation.