docs(lint): correct field value formats in write-lint-rules skill - #1128
Draft
jvegmond-tech wants to merge 1 commit into
Draft
jvegmond-tech wants to merge 1 commit into
jvegmond-tech wants to merge 1 commit into
Conversation
The reference documented three values that do not match what the runtime returns. Each mismatch makes a rule match nothing and report a clean pass, which is indistinguishable from the project being healthy. - entity_type is normalised to Persistent/NonPersistent/View in LintContext.Entities (context.go CASE), not lower case. The SEC001 example rule in this document used "persistent" and so matched no entity at all. - permission.access_type is written upper case by builder_permissions.go (CREATE/READ/WRITE/DELETE/EXECUTE/VIEW/ACCESS/MEMBER_READ/MEMBER_WRITE). - permission.module_role_name is qualified (Sales.Admin), which matters because rules compare it against user_role.module_roles.
AI Code ReviewCritical Issues
Moderate Issues
Minor Issues
What Looks Good
Recommendation Automated review via OpenRouter (Nemotron Super 120B) — workflow source |
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference documented three values that do not match what the runtime returns. Each mismatch makes a rule match nothing and report a clean pass, which is indistinguishable from the project being healthy.
Verified in the mxcli dev container: - make build — passes - go test ./mdl/linter/... — passes (mdl/linter and mdl/linter/rules)