In the contribution guidelines, change the Generated-By label to Assisted-By - #334
Open
GeertJohan wants to merge 1 commit into
Open
In the contribution guidelines, change the Generated-By label to Assisted-By#334GeertJohan wants to merge 1 commit into
GeertJohan wants to merge 1 commit into
Conversation
✅ Deploy Preview for metal-stack-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Assisted-by is definitely better, but I never saw anyone really adding this into the commit messages (me included). What is used consistently is the PR template for indication. So we either have to be more strict or we remove this paragraph from the contribution guideline. I think I would vote for option two if possible. @metal-stack/website-maintainers What is your take on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be a little bit nit-picky. I think "Generated-By' should be reserved for commits that are purely generated by tooling (e.g. dependabot?). Also I belive that using "Assisted" conveys better that the final commit is still the responsibility of the person who created it.
https://docs.kernel.org/process/coding-assistants.html