Skip to content

Upload to the ESP component registry - #378

Merged
Narukara merged 1 commit into
kiltedfrom
feat/upload_esp_registry
Aug 10, 2026
Merged

Upload to the ESP component registry#378
Narukara merged 1 commit into
kiltedfrom
feat/upload_esp_registry

Conversation

@Narukara

@Narukara Narukara commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

See #369

Publish Kilted as version 25.0.0.

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@Narukara, all pull requests must be targeted towards the rolling development branch.
Once merged into rolling, it is possible to backport to kilted, but it must be in rolling
to have these changes reflected in new distributions.

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@Narukara
Narukara force-pushed the feat/upload_esp_registry branch from 667746d to bbc54dd Compare August 6, 2026 04:01

@Amronos Amronos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks good to me. Before merging this PR, do we need a component with the name micro-ros/micro_ros_espidf_component created in the ESP component registry, or has that already been done? cc: @EugenioCollado

@Narukara

Narukara commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

do we need a component with the name micro-ros/micro_ros_espidf_component created in the ESP component registry

I had the same concern. The MR CI dry run passed, but it appears that upload-components-ci-action does not validate permissions in dry-run mode. We should still confirm this with him.

@Narukara

Narukara commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Another minor issue is that the banner in the README does not render correctly in the registry. It may need to use a URL such as https://raw.githubusercontent.com/.... Also, switching images based on the light or dark theme is somewhat difficult in the registry.

@EugenioCollado EugenioCollado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narukara

Copy link
Copy Markdown
Contributor Author

Before merging this PR, do we need a component with the name micro-ros/micro_ros_espidf_component created in the ESP component registry

I tested this on https://components-staging.espressif.com/, and it turns out that a component does not need to be created manually in advance before it can be uploaded. It works as long as Trusted Uploaders are configured at the namespace level.

@Narukara
Narukara merged commit 76df61e into kilted Aug 10, 2026
28 checks passed
@Narukara
Narukara deleted the feat/upload_esp_registry branch August 10, 2026 08:56
@Narukara

Copy link
Copy Markdown
Contributor Author

Anyway, I merged the PR, and the CI is now failing with an authentication error. This suggests that the previous Trusted Uploaders configuration was set at the component level, and the component name is not the one we want.

At this point, we need to do one of the following:

  • Configure Trusted Uploaders at the namespace level to allow uploads from this repository; or
  • Create the micro_ros_espidf_component component under the micro-ros namespace first, and then configure Trusted Uploaders for that component. I would recommend this option.

@EugenioCollado, could you help set this up? I assume the setup would look something like this:

图片

Once the configuration is in place, rerunning the upload job should be enough.

@EugenioCollado

Copy link
Copy Markdown
Contributor

I have done the steps for the second option and rerun the workflow and it is green now: https://github.com/micro-ROS/micro_ros_espidf_component/actions/runs/31372302915/job/93424230482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants