Remove redundant basic multithreaded benchmark - #8227
Merged
Amaury Chamayou (achamayou) merged 2 commits intoAug 28, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34d53872-5b23-4028-a831-822fdbb55b58
Copilot started reviewing on behalf of
Amaury Chamayou (achamayou)
August 27, 2026 21:04
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies CCF’s performance/benchmark test registration by removing the redundant Piccolo-backed pi_basic_mt test and documenting that the existing Locust-based basic benchmark already exercises multi-threaded behavior under the benchmark workflow configuration.
Changes:
- Remove the
pi_basic_mtPiccolo performance test from the CMake test registrations. - Update the
pi_basic_blocking_locustcomment to describe its relationship to multi-threaded coverage.
Custom instructions used
- None (no
.github/copilot-instructions.md/.github/instructions/*files were loaded directly during this review)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Eddy Ashton (eddyashton)
approved these changes
Aug 28, 2026
Amaury Chamayou (achamayou)
deleted the
achamayou-port-basic-benchmark-locust
branch
August 28, 2026 08:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pi_basic_mtperformance testpi_basic_blocking_locustalready exercises every configured worker threadRationale
The benchmark workflows configure
WORKER_THREADS=2, which is passed topi_basic_blocking_locustthrough the common network test arguments. Its 320 concurrent Locust connections already cover the multi-threaded basic workload, so adding another blocking Locust replacement would duplicate coverage.Validation
BUILD_TESTS=ONandWORKER_THREADS=2pi_basic_blocking_locustwith--worker-threads 2and nopi_basic_mtCMakeLists.txtwith gersemi 0.27.0