Skip to content

Remove redundant basic multithreaded benchmark - #8227

Merged
Amaury Chamayou (achamayou) merged 2 commits into
mainfrom
achamayou-port-basic-benchmark-locust
Aug 28, 2026
Merged

Remove redundant basic multithreaded benchmark#8227
Amaury Chamayou (achamayou) merged 2 commits into
mainfrom
achamayou-port-basic-benchmark-locust

Conversation

@achamayou

Copy link
Copy Markdown
Member

Summary

  • remove the Piccolo-backed pi_basic_mt performance test
  • document that pi_basic_blocking_locust already exercises every configured worker thread

Rationale

The benchmark workflows configure WORKER_THREADS=2, which is passed to pi_basic_blocking_locust through the common network test arguments. Its 320 concurrent Locust connections already cover the multi-threaded basic workload, so adding another blocking Locust replacement would duplicate coverage.

Validation

  • configured CMake with BUILD_TESTS=ON and WORKER_THREADS=2
  • confirmed the generated CTest registration includes pi_basic_blocking_locust with --worker-threads 2 and no pi_basic_mt
  • formatted CMakeLists.txt with gersemi 0.27.0
  • ran diff and ASCII integrity checks

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 34d53872-5b23-4028-a831-822fdbb55b58
Copilot AI lite review requested due to automatic review settings August 27, 2026 21:04
@achamayou
Amaury Chamayou (achamayou) requested a review from a team as a code owner August 27, 2026 21:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies CCF’s performance/benchmark test registration by removing the redundant Piccolo-backed pi_basic_mt test and documenting that the existing Locust-based basic benchmark already exercises multi-threaded behavior under the benchmark workflow configuration.

Changes:

  • Remove the pi_basic_mt Piccolo performance test from the CMake test registrations.
  • Update the pi_basic_blocking_locust comment to describe its relationship to multi-threaded coverage.

Custom instructions used

  • None (no .github/copilot-instructions.md / .github/instructions/* files were loaded directly during this review)

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CMakeLists.txt
@achamayou
Amaury Chamayou (achamayou) merged commit b15e05c into main Aug 28, 2026
13 checks passed
@achamayou
Amaury Chamayou (achamayou) deleted the achamayou-port-basic-benchmark-locust branch August 28, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants