fix: Validate schema property is not null - #2468
Merged
Vincent Biret (baywet) merged 2 commits intoAug 20, 2025
Merged
Conversation
Vincent Biret (baywet)
previously approved these changes
Aug 19, 2025
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
Member
|
Ciaran Liedeman (@cliedeman) with the other PR being merged first (#2459 ), the resource file is conflicting. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Ciaran Liedeman (cliedeman)
force-pushed
the
feat/validate-null-property
branch
2 times, most recently
from
August 19, 2025 13:44
ad500ce to
886afa1
Compare
Contributor
Author
|
Thanks Vincent Biret (@baywet). Updated |
Ciaran Liedeman (cliedeman)
force-pushed
the
feat/validate-null-property
branch
3 times, most recently
from
August 19, 2025 13:50
2a60c79 to
ae892d9
Compare
Ciaran Liedeman (cliedeman)
force-pushed
the
feat/validate-null-property
branch
from
August 19, 2025 14:23
ae892d9 to
5c9817c
Compare
Vincent Biret (baywet)
previously approved these changes
Aug 19, 2025
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
Vincent Biret (baywet)
enabled auto-merge
August 19, 2025 14:59
auto-merge was automatically disabled
August 19, 2025 20:10
Head branch was pushed to by a user without write access
Contributor
Author
|
Fixed tests |
Vincent Biret (baywet)
approved these changes
Aug 20, 2025
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
Vincent Biret (baywet)
enabled auto-merge (squash)
August 20, 2025 12:44
Vincent Biret (baywet)
merged commit Aug 20, 2025
3326022
into
microsoft:main
14 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/kiota#6846 throw error is schema property is null