Fix file access for "file" URI scheme - #2484
Merged
Merged
Conversation
Updated the file access method to use `absoluteUri.LocalPath` instead of `absoluteUri.AbsolutePath` when the URI scheme is "file". This change ensures correct file opening for local files.
Vincent Biret (baywet)
approved these changes
Sep 8, 2025
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
Vincent Biret (baywet)
enabled auto-merge
September 8, 2025 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Allow files with spaces in path to work
Updated the file access method to use
absoluteUri.LocalPathinstead ofabsoluteUri.AbsolutePathwhen the URI scheme is "file". This change ensures correct file opening for local files when there are escaped characters in the path such as spaces.