Skip to content

feat(library): add missing json schema properties - #2880

Merged
Vincent Biret (baywet) merged 9 commits into
mainfrom
feat/missing-json-schema-properties
Jun 9, 2026
Merged

feat(library): add missing json schema properties#2880
Vincent Biret (baywet) merged 9 commits into
mainfrom
feat/missing-json-schema-properties

Conversation

@baywet

Copy link
Copy Markdown
Member

Summary

  • add IOpenApiSchemaMissingProperties as a compatibility surface for the remaining JSON Schema 2020-12 schema keywords without breaking IOpenApiSchema
  • wire the new schema properties through OpenApiSchema, OpenApiSchemaReference, versioned readers, and 3.0 x-oai-* compatibility serialization
  • fix WriteJsonSchemaKeywords so nested schema-valued keywords serialize with the target version callback

Testing

  • dotnet build src\Microsoft.OpenApi\Microsoft.OpenApi.csproj --nologo
  • dotnet test test\Microsoft.OpenApi.Tests\Microsoft.OpenApi.Tests.csproj --nologo --no-build --filter "OpenApiSchemaTests|OpenApiSchemaReferenceTests|OpenApiSchemaSerializationTests"
  • dotnet test test\Microsoft.OpenApi.Readers.Tests\Microsoft.OpenApi.Readers.Tests.csproj --nologo --filter "OpenApiSchemaTests"

Closes #2877
Closes #2878
Closes #2879

Vincent Biret (baywet) and others added 2 commits June 9, 2026 12:08
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-code-quality

github-code-quality Bot commented Jun 9, 2026

Copy link
Copy Markdown

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall coverage in the feat/missing-json-sc... branch remains at 88%, unchanged from the main branch.

Show a code coverage summary of the most impacted files.
File main 21488c6 feat/missing-json-sc... 9cf0916 +/-
/home/runner/wo...emaReference.cs 93% 93% 0%
/home/runner/wo...penApiSchema.cs 99% 99% 0%
/home/runner/wo...Deserializer.cs 87% 90% +3%
/home/runner/wo...Deserializer.cs 87% 90% +3%
/home/runner/wo...Deserializer.cs 81% 86% +5%

Updated June 09, 2026 17:57 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

Vincent Biret (baywet) and others added 7 commits June 9, 2026 12:17
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@baywet
Vincent Biret (baywet) marked this pull request as ready for review June 9, 2026 17:55
@baywet
Vincent Biret (baywet) requested a review from a team as a code owner June 9, 2026 17:55
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
8.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@baywet Vincent Biret (baywet) self-assigned this Jun 9, 2026
@baywet
Vincent Biret (baywet) merged commit 9b1aed6 into main Jun 9, 2026
18 of 19 checks passed
@baywet
Vincent Biret (baywet) deleted the feat/missing-json-schema-properties branch June 9, 2026 18:34
Vincent Biret (baywet) added a commit that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants