Skip to content

Fixed a crash related to variadic tuple elements with intersections containing InstantiableNonPrimitive #64239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed a crash related to variadic tuple elements with intersections containing InstantiableNonPrimitive #64239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tsc/internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23707,7 +23707,9 @@ func (n *TupleNormalizer) normalize(c *Checker, elementTypes []*Type, elementInf
if info.flags&ElementFlagsVariadic != 0 {
if t.flags&TypeFlagsAny != 0 {
n.add(t, TupleElementInfo{flags: ElementFlagsRest, labeledDeclaration: info.labeledDeclaration})
} else if t.flags&TypeFlagsInstantiableNonPrimitive != 0 || c.isGenericMappedType(t) {
} else if someContainedType(t, func(t *Type) bool {
return t.flags&TypeFlagsInstantiableNonPrimitive != 0 || c.isGenericMappedType(t)
}) {
// Generic variadic elements stay as they are.
n.add(t, info)
} else if isTupleType(t) {
Expand Down Expand Up @@ -26893,6 +26895,13 @@ func everyType(t *Type, f func(*Type) bool) bool {
return f(t)
}

func someContainedType(t *Type, f func(*Type) bool) bool {
if t.flags&TypeFlagsUnionOrIntersection != 0 {
return core.Some(t.Types(), f)
}
return f(t)
}

func everyContainedType(t *Type, f func(*Type) bool) bool {
if t.flags&TypeFlagsUnionOrIntersection != 0 {
return core.Every(t.Types(), f)
Expand Down
10 changes: 10 additions & 0 deletions tsc/testdata/baselines/reference/compiler/recursiveConditionalCrash5.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
recursiveConditionalCrash5.ts(3,60): error TS2589: Type instantiation is excessively deep and possibly infinite.


==== recursiveConditionalCrash5.ts (1 errors) ====
// https://github.com/microsoft/TypeScript/issues/63040

type StringTreeArrayAsTuple<T> = (T extends [...infer R] ? [...StringTreeArrayAsTuple<R>] : never) & boolean;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
!!! error TS2589: Type instantiation is excessively deep and possibly infinite.

13 changes: 13 additions & 0 deletions tsc/testdata/baselines/reference/compiler/recursiveConditionalCrash5.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//// [tests/cases/compiler/recursiveConditionalCrash5.ts] ////

=== recursiveConditionalCrash5.ts ===
// https://github.com/microsoft/TypeScript/issues/63040

type StringTreeArrayAsTuple<T> = (T extends [...infer R] ? [...StringTreeArrayAsTuple<R>] : never) & boolean;
>StringTreeArrayAsTuple : Symbol(StringTreeArrayAsTuple, Decl(recursiveConditionalCrash5.ts, 0, 0))
>T : Symbol(T, Decl(recursiveConditionalCrash5.ts, 2, 28))
>T : Symbol(T, Decl(recursiveConditionalCrash5.ts, 2, 28))
>R : Symbol(R, Decl(recursiveConditionalCrash5.ts, 2, 53))
>StringTreeArrayAsTuple : Symbol(StringTreeArrayAsTuple, Decl(recursiveConditionalCrash5.ts, 0, 0))
>R : Symbol(R, Decl(recursiveConditionalCrash5.ts, 2, 53))

8 changes: 8 additions & 0 deletions tsc/testdata/baselines/reference/compiler/recursiveConditionalCrash5.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
//// [tests/cases/compiler/recursiveConditionalCrash5.ts] ////

=== recursiveConditionalCrash5.ts ===
// https://github.com/microsoft/TypeScript/issues/63040

type StringTreeArrayAsTuple<T> = (T extends [...infer R] ? [...StringTreeArrayAsTuple<R>] : never) & boolean;
>StringTreeArrayAsTuple : StringTreeArrayAsTuple<T>

6 changes: 6 additions & 0 deletions tsc/testdata/tests/cases/compiler/recursiveConditionalCrash5.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// @strict: true
// @noEmit: true

// https://github.com/microsoft/TypeScript/issues/63040

type StringTreeArrayAsTuple<T> = (T extends [...infer R] ? [...StringTreeArrayAsTuple<R>] : never) & boolean;