Skip to content

[2.0-stable] Cherry-pick: Fix errors from missing resource dll with version info (#6725) - #6776

Open
Manodasan Wignarajah (manodasanW) wants to merge 3 commits into
release/2.0-stablefrom
manodasanw/insights-2.0-release
Open

Manodasan Wignarajah (manodasanW) wants to merge 3 commits into
release/2.0-stablefrom
manodasanw/insights-2.0-release

Conversation

@manodasanW

Copy link
Copy Markdown
Member

Cherry-picks #6725 to release/2.0-stable.

The runtime package is what contains Microsoft.WindowsAppRuntime.Insights.Resource.dll as that is where we can say this runtime framework package is this version. But when someone uses individual component packages without the runtime package, that currently leads to errors due to the DLL is not there. Instead of erroring, we should safely handle these situations based on what info we can provide.

  • For Version info, we just return 0 or empty now when the dll is missing as we can't say what version it is given each component package can be a different version and there is no framework package involved.
  • For the IsSelfContained check that seems to also call this, that now returns true to indicate it is self-contained when this DLL isn't there.

The new behavior is guarded by runtime compatibility change VersionInfo_MissingResourceDllFallback (64191138). Disabling the change preserves the previous behavior.

A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b827f915-8160-4a92-84cc-c42ce5d787a8
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@manodasanW

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b827f915-8160-4a92-84cc-c42ce5d787a8
@manodasanW

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant