.NET: Document ILoggerFactory for UseFunctionInvocation - #8315
Open
mrchatam wants to merge 2 commits into
Open
Conversation
Pass the sample's ILoggerFactory into UseFunctionInvocation so tool failures are logged, and document both direct injection and Build(IServiceProvider) in the AgentOpenTelemetry README. Fixes a couple of README inaccuracies. Fixes microsoft#2352
agent-framework-automation
Bot
added
documentation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused code and documentation changes correctly address the linked logging issue.
Pull request overview
Documents and enables tool-execution exception logging in the AgentOpenTelemetry sample.
Changes:
- Passes
ILoggerFactorytoUseFunctionInvocation. - Documents direct injection and DI-based alternatives.
- Corrects the sample path and OpenTelemetry API name.
File summaries
| File | Description |
|---|---|
dotnet/samples/02-agents/AgentOpenTelemetry/README.md |
Adds logging guidance and corrects instructions. |
dotnet/samples/02-agents/AgentOpenTelemetry/Program.cs |
Enables detailed tool-failure logging. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ILoggerFactoryintoUseFunctionInvocation(loggerFactory)so tool-execution exceptions are logged (as clarified in .NET: execute_tool doesn't capture the failure in telemetry #2211).ILoggerFactoryinjection andBuild(IServiceProvider)..WithOpenTelemetry()→.UseOpenTelemetry()for the agent pipeline).Fixes #2352
Test plan
dotnet buildonAgentOpenTelemetry.csproj) when credentials are not required for compile