fix(gateway): reject non-object JSON request bodies - #587
Open
Tanjiahao (JiahaoTanXX) wants to merge 1 commit into
Open
fix(gateway): reject non-object JSON request bodies#587Tanjiahao (JiahaoTanXX) wants to merge 1 commit into
Tanjiahao (JiahaoTanXX) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The validation prevents the reported server-side failure and is adequately covered.
Pull request overview
Rejects non-object JSON payloads at the gateway before proxy processing.
Changes:
- Returns HTTP 400 for top-level scalar, array, or null JSON.
- Adds parameterized regression coverage.
File summaries
| File | Description |
|---|---|
agentlightning/server/routes/proxy.py |
Validates that parsed request bodies are objects. |
tests/server/test_endpoints.py |
Tests rejection of non-object JSON payloads. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pytest -q tests/server/test_endpoints.py(26 passed)ruff check .ruff format --check .python scripts/check_headers.pygit diff --check