Add IaC DB schema upgrade/downgrade scripts - #390
Open
Chanel (chanel-y) wants to merge 1 commit into
Open
Conversation
The IaC extractor shipped no schema-migration scripts, so any mismatch between a database's dbscheme and a query pack's dbscheme was fatal (e.g. MRVA "database is not compatible with a QL library" errors). The dbscheme changed when Bicep support (82 bicep_* relations) was removed and yaml_comments/empty_location were added. - Add upgrade step iac/ql/lib/upgrades/e360fadd.../ (old bicep -> current): deletes the 82 bicep_* relations (compatibility: backwards). - Add downgrade step iac/downgrades/6b6bd68.../ (current -> old bicep): restores empty bicep tables, drops yaml_comments/empty_location (compatibility: partial). - Bootstrap iac/downgrades as a pack (qlpack.yml, initial/) and add iac/ql/lib/upgrades/initial/, matching go/rust/swift layout. - Teach misc/scripts/prepare-db-upgrade.sh about the iac language. - Fix iac/scripts/create-extractor-pack.ps1 (was a stale QL-for-QL copy) to mirror the .sh and ship the downgrades folder. Verified with codeql 2.26.2: upgrading an old bicep DB to the current scheme and running an IaC query succeeds; downgrading a current DB back to the old scheme succeeds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IaC extractor shipped no schema-migration scripts, so any mismatch between a database's dbscheme and a query pack's dbscheme was fatal (e.g. MRVA "database is not compatible with a QL library" errors). The dbscheme changed when Bicep support (82 bicep_* relations) was removed and yaml_comments/empty_location were added.
Verified with codeql 2.26.2: upgrading an old bicep DB to the current scheme and running an IaC query succeeds; downgrading a current DB back to the old scheme succeeds.